New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update anonymous box list #12608
Update anonymous box list #12608
Conversation
This picks up the changes in https://bugzilla.mozilla.org/show_bug.cgi?id=1289624
This handles the changes in bug 1277131 and bug 1097499, and should allow us to remove the hacky fallback for anonymous boxes in stylo.
r? @emilio |
@bors-servo: r+ |
📌 Commit 2784f44 has been approved by |
Update anonymous box list These have drifted since we introduced them. Adding a few other misc commits while I'm at it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12608) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
The llvm_stable thing breaks the binding generation for me. If I pass it llvm38, I get this error:
If I pass it my local llvm trunk build, it works but makes changes like: -- a/ports/geckolib/gecko_bindings/bindings.rs
++ b/ports/geckolib/gecko_bindings/bindings.rs
@@ -147,7 +147,7 @@ use structs::nsIAtom;
pub type RawGeckoNode = nsINode;
pub enum Element { }
- pub type RawGeckoElement = Element;
+ pub type RawGeckoElement = ::std::os::raw::c_void;
pub type RawGeckoDocument = nsIDocument;
pub enum ServoNodeData { }
pub enum ServoComputedValues { } (all |
Hm, _clang_Cursor_isFunctionInlined and friends are LLVM39 symbols. The whole point of llvm_stable is that it avoids requiring llvm39 symbols, because we need to be on LLVM38 to have any chance at all of making LLVM a build-time requirement for Firefox. Can you debug why llvm_stable seems to be having the opposite effect as intended? |
I'll try, sure 😄 a clean build of bindgen didn't seem to change anything but I should try this again. |
Works now. I cleaned it again, reset env vars, and it's fine. |
These have drifted since we introduced them. Adding a few other misc commits while I'm at it.
This change is