Create mach fetch command
#12821
Merged
Create mach fetch command
#12821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
| @@ -34,6 +34,17 @@ def cargo(self, params): | |||
| if not params: | |||
| params = [] | |||
|
|
|||
| cargo_paths = [path.join('components', 'servo'), | |||
There was a problem hiding this comment.
These are also used in update_cargo, so this can be moved to the top level as a constant. Also, formatting nit, put each path on a new line with a trailing comma:
CARGO_PATHS = [
path.join(...),
]
|
Addressed all reviews. |
|
LGTM. r? @aneeshusa |
| CARGO_PATHS = [ | ||
| path.join('components', 'servo'), | ||
| path.join('ports', 'cef'), | ||
| path.join('ports', 'geckolib') |
There was a problem hiding this comment.
nit: add a trailing comma at the end of the line
|
LGTM aside from the one nit. |
aneeshusa
added
S-needs-code-changes
highfive
added
S-awaiting-review
|
done. |
|
@bors-servo r+ |
|
📌 Commit d805e85 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 12, 2016
Create `mach fetch` command - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12775. r? @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12821) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsmach updatecommand to update everything needed to build #12775.r? @larsbergstrom
This change is