-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for anonymous boxes #1461
fix for anonymous boxes #1461
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/524 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
nearest_ancestor_element.parent_node().expect("no nearest element?!"); | ||
} | ||
|
||
if nearest_ancestor_element.style().get().Box.display == display::block { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this only for blocks? We have the same for inlines <span><em>foo</em> bar</span>
and possibly other types of boxes
@pcwalton, could you look at https://critic.hoppipolla.co.uk/showcomment?chain=1039 ? |
fix for anonymous boxes.
http://www.w3.org/TR/CSS2/visuren.html#anonymous-block-level