Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Add parsing support for functional non-ts pseudoclasses, add stub -moz-system-metric pseudo #15976

Merged
merged 1 commit into from Mar 16, 2017
Merged

stylo: Add parsing support for functional non-ts pseudoclasses, add stub -moz-system-metric pseudo #15976

merged 1 commit into from Mar 16, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 16, 2017 •
edited by larsbergstrom

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/wrapper.rs, components/style/gecko/selector_parser.rs, components/style/gecko/non_ts_pseudo_class_list.rs
  • @emilio: components/style/gecko/wrapper.rs, components/style/gecko/selector_parser.rs, components/style/gecko/non_ts_pseudo_class_list.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 16, 2017
@Manishearth
stylo: Add parsing support for functional non-ts pseudoclasses, add s…
b37f991 
…tub -moz-system-metric pseudo

MozReview-Commit-ID: KADDH6adZqR
@Manishearth
Copy link
Member Author

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit b37f991 has been approved by heycam

@highfive highfive assigned heycam and unassigned wafflespeanut Mar 16, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 16, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit b37f991 with merge 78c8edf...

bors-servo pushed a commit that referenced this pull request Mar 16, 2017
Auto merge of #15976 - Manishearth:stylo-stub-system-metric, r=heycam
78c8edf 
stylo: Add parsing support for functional non-ts pseudoclasses, add stub -moz-system-metric pseudo

r=heycam from https://bugzilla.mozilla.org/show_bug.cgi?id=1341086

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15976)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing 78c8edf to master...

@bors-servo bors-servo merged commit b37f991 into servo:master Mar 16, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 16, 2017
@Manishearth Manishearth deleted the stylo-stub-system-metric branch May 7, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Manishearth @highfive @bors-servo @heycam @wafflespeanut