Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: Ensure we don't suppress reflows when stylesheets are dirty. #16618

Merged
merged 1 commit into from
Apr 26, 2017
Merged

script: Ensure we don't suppress reflows when stylesheets are dirty. #16618

merged 1 commit into from
Apr 26, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Apr 26, 2017 •
edited by larsbergstrom

I suspect this will prevent some intermittentness in #16617

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/document.rs
  • @KiChjang: components/script/dom/document.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 26, 2017
@emilio
Copy link
Member Author

emilio commented Apr 26, 2017

Well, actually, I don't think so, since the reflow is not for_display, but still could be a correctness issue.

r? @nox

@nox
Copy link
Contributor

nox commented Apr 26, 2017

@bors-servo r+ p=23

@bors-servo
Copy link
Contributor

📌 Commit 69fd9a3 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 26, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 69fd9a3 with merge 4e70e10...

bors-servo pushed a commit that referenced this pull request Apr 26, 2017
Auto merge of #16618 - emilio:dirty-doc, r=nox
4e70e10 
script: Ensure we don't suppress reflows when stylesheets are dirty.

I suspect this will prevent some intermittentness in #16617

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16618)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: nox
Pushing 4e70e10 to master...

@bors-servo bors-servo merged commit 69fd9a3 into servo:master Apr 26, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilio @highfive @nox @bors-servo