-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialization of font-feature-settings #16853
Fix serialization of font-feature-settings #16853
Conversation
r? @emilio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with or without that bit.
0 => write!(dest, "\"{}\" off",str_print), | ||
x => write!(dest, "\"{}\" {}", str_print, x) | ||
1 => Ok(()), | ||
0 => write!(dest, " off"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dest.write_str("off")
instead may be slightly more efficient.
c55ff4c
to
7d37804
Compare
@bors-servo r=emilio |
📌 Commit 7d37804 has been approved by |
…=emilio Fix serialization of font-feature-settings <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16853) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
This change is