Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access to CSSKeyframesRule and CSSKeyframeRule for stylo #16944

Merged
merged 5 commits into from May 19, 2017
Merged

Implement access to CSSKeyframesRule and CSSKeyframeRule for stylo #16944

merged 5 commits into from May 19, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented May 19, 2017 •
edited by larsbergstrom

This is the Servo side change for bug 1345697.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/keyframes.rs, components/style/gecko/arc_types.rs, components/style/stylesheets.rs
  • @emilio: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs, components/style/keyframes.rs, components/style/gecko/arc_types.rs, components/style/stylesheets.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 19, 2017
@upsuper
Copy link
Contributor Author

upsuper commented May 19, 2017

@bors-servo r=heycam p=5

@bors-servo
Copy link
Contributor

📌 Commit 6327eeb has been approved by heycam

@highfive highfive assigned heycam and unassigned asajeffrey May 19, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 6327eeb with merge c7aefed...

bors-servo pushed a commit that referenced this pull request May 19, 2017
Auto merge of #16944 - upsuper:bug1345697, r=heycam
c7aefed 
Implement access to CSSKeyframesRule and CSSKeyframeRule for stylo

This is the Servo side change for [bug 1345697](https://bugzilla.mozilla.org/show_bug.cgi?id=1345697).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16944)
<!-- Reviewable:end -->
@upsuper
Copy link
Contributor Author

upsuper commented May 19, 2017

@bors-servo r-

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 19, 2017
@upsuper
Copy link
Contributor Author

upsuper commented May 19, 2017

@bors-servo r=heycam p=5

@bors-servo
Copy link
Contributor

📌 Commit f7c5e4b has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit f7c5e4b with merge eda6430...

bors-servo pushed a commit that referenced this pull request May 19, 2017
Auto merge of #16944 - upsuper:bug1345697, r=heycam
eda6430 
Implement access to CSSKeyframesRule and CSSKeyframeRule for stylo

This is the Servo side change for [bug 1345697](https://bugzilla.mozilla.org/show_bug.cgi?id=1345697).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16944)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing eda6430 to master...

@bors-servo bors-servo merged commit f7c5e4b into servo:master May 19, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 19, 2017
@upsuper upsuper deleted the bug1345697 branch May 19, 2017 06:11
@bors-servo bors-servo mentioned this pull request May 19, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upsuper @highfive @bors-servo @asajeffrey @heycam