Rewrite parallel.rs #16971
Merged
Rewrite parallel.rs #16971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
May 20, 2017
Rewrite parallel.rs https://bugzilla.mozilla.org/show_bug.cgi?id=1366347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16971) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
May 20, 2017
Rewrite parallel.rs https://bugzilla.mozilla.org/show_bug.cgi?id=1366347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16971) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
May 20, 2017
Rewrite parallel.rs https://bugzilla.mozilla.org/show_bug.cgi?id=1366347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16971) <!-- Reviewable:end -->
|
Ok, out of time before bed and I want to get this into the queue. @bors-servo r=emilio p=1 |
|
📌 Commit b298f06 has been approved by |
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
@bors-servo retry |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #16972) made this pull request unmergeable. Please resolve the merge conflicts. |
highfive
added
S-needs-rebase
highfive
added
the
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit a182ae4 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 21, 2017
Rewrite parallel.rs https://bugzilla.mozilla.org/show_bug.cgi?id=1366347 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16971) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
3 tasks
bors-servo
pushed a commit
that referenced
this pull request
Jun 8, 2017
Parallel layout optimizations This takes some of the optimizations made to parallel styling in #16971 and applies them to parallel layout. Specifically: * Reduce the chunk size, to increase chances for parallelism on trees with small fan-out. * Reduce allocations by using SmallVec. * Reduce task switching by processing up to one chunk of children within the same rayon task as the parent. This cuts the "Primary Layout Pass" time in **half** on the MySpace page from [tp5n], and on my other real-world test pages it is a small improvement or close to no change. [tp5n]: https://wiki.mozilla.org/Buildbot/Talos/Tests#tp5n_pages_set --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they affect performance only <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17192) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1366347
This change is