Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse Rect<T> some more #17071

Merged
merged 3 commits into from May 30, 2017
Merged

Reuse Rect<T> some more #17071

merged 3 commits into from May 30, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented May 28, 2017 •
edited by larsbergstrom

This change is Reviewable

nox added 3 commits May 28, 2017 14:36
@nox
Make Rect<T> a struct tuple
4144dc7 
It makes no sense to have named fields in some cases, notably to reuse
Rect<T> in BorderRadius<T>.
@nox
Refactor BorderRadius and move it to the border modules
af3ede4 
BorderRadius now parses itself reusing Rect<T>.
@nox
Rename BorderRadiusSize to BorderCornerSize
862fc4f
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/basic_shape.rs, components/style/values/generics/rect.rs, components/style/values/computed/mod.rs, components/style/gecko/conversions.rs, components/style/properties/longhand/outline.mako.rs and 13 more
  • @emilio: components/layout/display_list_builder.rs, components/style/values/specified/basic_shape.rs, components/style/values/generics/rect.rs, components/style/values/computed/mod.rs, components/style/gecko/conversions.rs and 15 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 28, 2017
@nox
Copy link
Contributor Author

nox commented May 28, 2017

r? @emilio
@bors-servo try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4538cf29cd803df5c49ec9abdde00b81ae09a8de

@highfive highfive assigned emilio and unassigned wafflespeanut May 28, 2017
@bors-servo
Copy link
Contributor

⌛ Trying commit 862fc4f with merge c73a80b...

bors-servo pushed a commit that referenced this pull request May 28, 2017
Auto merge of #17071 - servo:derive-all-the-things, r=<try>
c73a80b 
Reuse Rect<T> some more
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

@emilio
Copy link
Member

emilio commented May 29, 2017

What's the rationale for converting Rect to a tuple? I find that somewhat confusing, over all because in layout we represent rects as (Origin, Size), which makes the tuple indices very confusing.

@nox
Copy link
Contributor Author

nox commented May 30, 2017

What's the rationale for converting Rect to a tuple?

Not all values that behave that way correspond to the four sides of a rectangle. For example as part of border-radius, the values correspond to corners.

@emilio
Copy link
Member

emilio commented May 30, 2017

@bors-servo r+

Perhaps those should be newtypes... But not going to block on that. r=me

@bors-servo
Copy link
Contributor

📌 Commit 862fc4f has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 30, 2017
@nox
Copy link
Contributor Author

nox commented May 30, 2017

@bors-servo p=1

@bors-servo
Copy link
Contributor

⌛ Testing commit 862fc4f with merge 433d689...

bors-servo pushed a commit that referenced this pull request May 30, 2017
Auto merge of #17071 - servo:derive-all-the-things, r=emilio
433d689 
Reuse Rect<T> some more

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17071)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 433d689 to master...

@bors-servo bors-servo merged commit 862fc4f into master May 30, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @bors-servo @emilio @wafflespeanut