Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WR (CPU text optimizations, image format renames). #17352

Merged
merged 1 commit into from Jun 16, 2017
Merged

Update WR (CPU text optimizations, image format renames). #17352

merged 1 commit into from Jun 16, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Jun 16, 2017 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/canvasrenderingcontext2d.rs, components/net/image_cache.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/script/dom/webglrenderingcontext.rs and 1 more
  • @fitzgen: components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/paintworkletglobalscope.rs
  • @emilio: components/layout/display_list_builder.rs, components/canvas/webgl_paint_thread.rs, components/script/dom/webglrenderingcontext.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 16, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify net, layout, and script code, but no tests are modified. Please consider adding a test!

@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

r? anyone

@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

@Eijebong FYI, this PR brings WR up to date in Servo. In case it doesn't land before your serde 1.0 changes are ready to go, you can use this as a base for the required WR API changes.

@emilio
Copy link
Member

emilio commented Jun 16, 2017

Looks good, though I'd expect some WebGL tests to fail... Let's see.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e7b1e04 has been approved by emilio

@highfive highfive assigned emilio and unassigned Manishearth Jun 16, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 16, 2017
@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

@emilio Tests should be OK - it's just a rename of the format to match the actual layout. There's no actual byte ordering changes.

@bors-servo
Copy link
Contributor

⌛ Testing commit e7b1e04 with merge e1bce24...

bors-servo pushed a commit that referenced this pull request Jun 16, 2017
Auto merge of #17352 - glennw:update-wr-faster-text, r=emilio
e1bce24 
Update WR (CPU text optimizations, image format renames).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17352)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing e1bce24 to master...

@bors-servo bors-servo merged commit e7b1e04 into servo:master Jun 16, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 16, 2017
@bors-servo bors-servo mentioned this pull request Jun 16, 2017
Merged
3 tasks
@MortimerGoro MortimerGoro mentioned this pull request Jul 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glennw @highfive @emilio @bors-servo @Manishearth @gw3583