Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Get restyle hints right in presence of XBL. #17429

Merged
merged 4 commits into from
Jun 20, 2017
Merged

style: Get restyle hints right in presence of XBL. #17429

merged 4 commits into from
Jun 20, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Jun 20, 2017 •
edited by larsbergstrom

Fixes bug 1371130.

This change is Reviewable

@emilio
style: expose methods to get ::before, ::after, and the other NAC.
b894c36 
Reviewed-By: heycam
Bug: 1371130

MozReview-Commit-ID: JVeQevmjI3j
@emilio
style: Invalidate style using the DOM tree, and scan pseudo-elements …
459b22a 
…and NAC separately.

Bug: 1371130
Reviewed-By: heycam
MozReview-Commit-ID: IU1TbVf4Zz9
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/generated/atom_macro.rs, components/style/invalidation/element/invalidator.rs and 2 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 20, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Jun 20, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 7633230 has been approved by heycam

@highfive highfive assigned heycam and unassigned Manishearth Jun 20, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 20, 2017
@emilio
Copy link
Member Author

emilio commented Jun 20, 2017

@bors-servo p=10

  • Coordiland

@emilio
style: Get restyle hints right in presence of XBL.
ae5a6c9 
Bug: 1371130
Reviewed-By: heycam
MozReview-Commit-ID: 56lMyXEYT1I
@emilio
style: Update bindings.
59a0d66
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 20, 2017
@emilio
Copy link
Member Author

emilio commented Jun 20, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 59a0d66 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 20, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 59a0d66 with merge f5a6168...

bors-servo pushed a commit that referenced this pull request Jun 20, 2017
Auto merge of #17429 - emilio:restyle-hints-xbl, r=heycam
f5a6168 
style: Get restyle hints right in presence of XBL.

Fixes bug 1371130.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing f5a6168 to master...

@bors-servo bors-servo merged commit 59a0d66 into servo:master Jun 20, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 20, 2017
@bors-servo bors-servo mentioned this pull request Jun 20, 2017
Closed
@emilio emilio mentioned this pull request Jun 20, 2017
Merged
bors-servo pushed a commit that referenced this pull request Jun 20, 2017
Auto merge of #17431 - emilio:restyle-hints-xbl, r=emilio
b50cf33 
style: Cleanup after #17427, and remove extra-optimistic optimization added in #17429.

This just addresses my review comments in #17427, and removes a wrong optimization I added in #17429 thinking it was correct.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17431)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @bors-servo @heycam @Manishearth