Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cssparser version to 0.16.1 in toml files #17484

Merged
merged 1 commit into from Jun 23, 2017
Merged

Bump cssparser version to 0.16.1 in toml files #17484

merged 1 commit into from Jun 23, 2017

Conversation

canova
Copy link
Contributor

@canova canova commented Jun 22, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @fitzgen: components/script/Cargo.toml, components/script_layout_interface/Cargo.toml
  • @emilio: components/style/Cargo.toml, ports/geckolib/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 22, 2017
@emilio
Copy link
Member

emilio commented Jun 22, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 5362c5e has been approved by emilio

@highfive highfive assigned emilio and unassigned asajeffrey Jun 22, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 22, 2017
@canova
Copy link
Contributor Author

canova commented Jun 22, 2017

@bors-servo p=10
(Sorry but autoland fails because of this)

@bors-servo
Copy link
Contributor

⌛ Testing commit 5362c5e with merge efed75a...

bors-servo pushed a commit that referenced this pull request Jun 22, 2017
Auto merge of #17484 - canaltinova:upup, r=emilio
efed75a 
Bump cssparser version to 0.16.1 in toml files

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17484)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing efed75a to master...

@bors-servo bors-servo merged commit 5362c5e into servo:master Jun 23, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 23, 2017
@canova canova deleted the upup branch June 23, 2017 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@canova @highfive @emilio @bors-servo @asajeffrey