Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: properly handle ::before/::after rules applying to replaced elements #17593

Merged
merged 1 commit into from Jul 3, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Jul 3, 2017

Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7


This change is Reviewable

…ements.

Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7
@highfive
Copy link

highfive commented Jul 3, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/matching.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 3, 2017
@highfive
Copy link

highfive commented Jul 3, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Jul 3, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit a4b754c has been approved by heycam

@highfive highfive assigned heycam and unassigned KiChjang Jul 3, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 3, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit a4b754c with merge e3fc153...

bors-servo pushed a commit that referenced this pull request Jul 3, 2017
stylo: properly handle ::before/::after rules applying to replaced elements

Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 3, 2017
@emilio
Copy link
Member Author

emilio commented Jul 3, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit e2bf7d0 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 3, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e2bf7d0 with merge c17134c...

bors-servo pushed a commit that referenced this pull request Jul 3, 2017
stylo: properly handle ::before/::after rules applying to replaced elements

Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17593)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing c17134c to master...

@bors-servo bors-servo merged commit e2bf7d0 into servo:master Jul 3, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants