Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Allow styles to be computed ignoring existing element data. #17972

Merged
merged 2 commits into from Aug 5, 2017
Merged

style: Allow styles to be computed ignoring existing element data. #17972

merged 2 commits into from Aug 5, 2017

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Aug 4, 2017 •
edited by SimonSapin

@highfive
Copy link

highfive commented Aug 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/traversal.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/traversal.rs
  • @emilio: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs, components/style/traversal.rs

@highfive
Copy link

highfive commented Aug 4, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 4, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 4, 2017

Reviewed by bholley in the bug.

@bors-servo r=bholley p=1

@bors-servo
Copy link
Contributor

📌 Commit 039ec02 has been approved by bholley

@highfive highfive assigned bholley and unassigned metajack Aug 4, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 4, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 039ec02 with merge 29cfd8d...

bors-servo pushed a commit that referenced this pull request Aug 4, 2017
Auto merge of #17972 - heycam:ignore-existing, r=bholley
29cfd8d 
style: Allow styles to be computed ignoring existing element data.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1384824.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17972)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - android

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 4, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 4, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 4, 2017

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit 2c74d88 has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 4, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 2c74d88 with merge 0d5b6fd...

bors-servo pushed a commit that referenced this pull request Aug 4, 2017
Auto merge of #17972 - heycam:ignore-existing, r=bholley
0d5b6fd 
style: Allow styles to be computed ignoring existing element data.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1384824.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17972)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 4, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Aug 4, 2017
@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 5, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 5, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 5, 2017

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit 75f8c28 has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 5, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 75f8c28 with merge d2921a0...

bors-servo pushed a commit that referenced this pull request Aug 5, 2017
Auto merge of #17972 - heycam:ignore-existing, r=bholley
d2921a0 
style: Allow styles to be computed ignoring existing element data.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1384824.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17972)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - windows-msvc-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 5, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 5, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 5, 2017

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit bb44c0a has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 5, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit bb44c0a with merge ac37f81...

bors-servo pushed a commit that referenced this pull request Aug 5, 2017
Auto merge of #17972 - heycam:ignore-existing, r=bholley
ac37f81 
style: Allow styles to be computed ignoring existing element data.

From https://bugzilla.mozilla.org/show_bug.cgi?id=1384824.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17972)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing ac37f81 to master...

@bors-servo bors-servo merged commit bb44c0a into servo:master Aug 5, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 5, 2017
@heycam
Copy link
Contributor Author

heycam commented Aug 5, 2017

Hmm, I didn't mean to include the font-family related commit in this PR. Will back out in a separate PR.

@heycam heycam mentioned this pull request Aug 5, 2017
Merged
bors-servo pushed a commit that referenced this pull request Aug 5, 2017
Auto merge of #17979 - heycam:font-family-revert, r=heycam
e0d2278 
style: Revert font-family serialization commit #17972

This reverts commit 4f525f6.

I accidentally included some unrelated changes in #17972, so backing out here.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17979)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Aug 5, 2017
Auto merge of #17979 - heycam:font-family-revert, r=heycam
40315a6 
style: Revert font-family serialization commit #17972

This reverts commit 4f525f6.

I accidentally included some unrelated changes in #17972, so backing out here.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17979)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@heycam @highfive @bors-servo @metajack @bholley