style: Rework how precomputed pseudo stuff works, to avoid malloc/free churn. #17992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
|
r? @heycam |
|
(or @bholley) |
emilio
force-pushed
the
rework-precomputed-pseudo
branch
4 times, most recently
from
d15ef6b
to
70dfaf8
Compare
heycam
reviewed
Aug 8, 2017
components/style/stylist.rs
Outdated
| continue; | ||
| } | ||
|
|
||
| self.precomputed_pseudo_element_decls |
There was a problem hiding this comment.
(It would be nice if we could handle the precomputed case separately, above the match, so we can can all of the normal rule collection bits together, but it's not a big deal.)
|
@bors-servo delegate+ Much more sensible, thanks. :-) |
|
✌️ @emilio can now approve this pull request |
…e churn. This showed up in a few profiles, and was an easy improvement. MozReview-Commit-ID: HVqATaSB2Ak Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
emilio
force-pushed
the
rework-precomputed-pseudo
branch
from
70dfaf8
to
121e2d5
Compare
|
Yup, agreed, done :) @bors-servo r=heycam |
|
📌 Commit 121e2d5 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 8, 2017
style: Rework how precomputed pseudo stuff works, to avoid malloc/free churn. This showed up in a few profiles, and was an easy improvement. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17992) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up in a few profiles, and was an easy improvement.
This change is