Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue cleaning up the traversal entry point machinery #18026

Merged
merged 3 commits into from Aug 9, 2017
Merged

Continue cleaning up the traversal entry point machinery #18026

merged 3 commits into from Aug 9, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Aug 9, 2017 •
edited by SimonSapin

@bholley
Unrelated: Add a comment for Gecko bug 1368291.
c92f883 
Bundling this in to avoid an extra servo push.
@bholley
Add some logging to the traversal.
2a73717 
MozReview-Commit-ID: 3PzkUtEsa6p
@bholley
Be more careful about the flags we clear for forgetful traversals.
49bdb5b 
MozReview-Commit-ID: ETDL8KsInAn
@highfive
Copy link

highfive commented Aug 9, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/data.rs, components/style/traversal.rs, components/style/gecko/pseudo_element_definition.mako.rs
  • @emilio: components/style/data.rs, ports/geckolib/glue.rs, components/style/traversal.rs, components/style/gecko/pseudo_element_definition.mako.rs

@highfive
Copy link

highfive commented Aug 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 9, 2017
@bholley
Copy link
Contributor Author

bholley commented Aug 9, 2017

@bors-servo r=emilio p=2

@bors-servo
Copy link
Contributor

📌 Commit 49bdb5b has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 9, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 49bdb5b with merge 2b92a7e...

bors-servo pushed a commit that referenced this pull request Aug 9, 2017
Auto merge of #18026 - bholley:continue_traversal_cleanup, r=emilio
2b92a7e 
Continue cleaning up the traversal entry point machinery

https://bugzilla.mozilla.org/show_bug.cgi?id=1388623

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18026)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 2b92a7e to master...

@bors-servo bors-servo merged commit 49bdb5b into servo:master Aug 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bholley @highfive @bors-servo @emilio