Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -moz-appearance animatable #18066

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

dadaa
Copy link
Contributor

@dadaa dadaa commented Aug 14, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/properties/longhand/box.mako.rs
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/properties/longhand/box.mako.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/properties/longhand/box.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 14, 2017
@dadaa
Copy link
Contributor Author

dadaa commented Aug 14, 2017

These patches have been reviewed by @hiikezoe

@birtles
Copy link
Contributor

birtles commented Aug 14, 2017

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @dadaa can now approve this pull request

@dadaa
Copy link
Contributor Author

dadaa commented Aug 14, 2017

Thanks, @birtles !

@bors-servo r=hiro

@bors-servo
Copy link
Contributor

📌 Commit cdea3d2 has been approved by hiro

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 14, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit cdea3d2 with merge f93c6df...

bors-servo pushed a commit that referenced this pull request Aug 14, 2017
Make -moz-appearance animatable

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes. The test code is patch part 2 in https://bugzilla.mozilla.org/show_bug.cgi?id=1382138

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18066)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: hiro
Pushing f93c6df to master...

@bors-servo bors-servo merged commit cdea3d2 into servo:master Aug 14, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants