Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use the XBL styleset quirks mode to match XBL rules. #18794

Merged
merged 1 commit into from Oct 9, 2017
Merged

style: use the XBL styleset quirks mode to match XBL rules. #18794

merged 1 commit into from Oct 9, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Oct 9, 2017 •
edited by SimonSapin

This fixes bug 1405543.

MozReview-Commit-ID: Dv3mt3Fb8Yp

This change is Reviewable

@emilio
style: use the XBL styleset quirks mode to match XBL rules.
100dd18 
This fixes bug 1405543.

MozReview-Commit-ID: Dv3mt3Fb8Yp
@highfive
Copy link

highfive commented Oct 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/data.rs, components/style/stylist.rs
  • @canaltinova: components/style/gecko/data.rs, components/style/stylist.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 9, 2017
@highfive
Copy link

highfive commented Oct 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Oct 9, 2017

r? @heycam

@highfive highfive assigned heycam and unassigned mbrubeck Oct 9, 2017
@emilio
Copy link
Member Author

emilio commented Oct 9, 2017

@bors-servo r=heycam p=1

@bors-servo
Copy link
Contributor

📌 Commit 100dd18 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 9, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 100dd18 with merge 604cc4e...

bors-servo pushed a commit that referenced this pull request Oct 9, 2017
Auto merge of #18794 - emilio:xbl-quirks-mode, r=heycam
604cc4e 
style: use the XBL styleset quirks mode to match XBL rules.

This fixes bug 1405543.

MozReview-Commit-ID: Dv3mt3Fb8Yp

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18794)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing 604cc4e to master...

@bors-servo bors-servo merged commit 100dd18 into servo:master Oct 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heycam heycam heycam approved these changes

Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @bors-servo @heycam @mbrubeck