Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Split the invalidation processing from the invalidator step. #18847

Merged
merged 7 commits into from Oct 13, 2017
Merged

style: Split the invalidation processing from the invalidator step. #18847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9b3e59
style: Split the invalidation collection from the invalidator step.
emilio Oct 12, 2017
a5e2f2c
style: Isolate all the restyling related logic in the invalidator in …
emilio Oct 12, 2017
557353c
style: Move the bounds up in InvalidationProcessor.
emilio Oct 12, 2017
9e61c19
style: Unify invalidated_child with invalidated_descendants.
emilio Oct 12, 2017
ecdb10e
Be more precise in should_process_descendants.
emilio Oct 12, 2017
9034e6a
style: Add a way to skip the "invalidation on eager pseudo invalidate…
emilio Oct 12, 2017
e447f81
style: Make InvalidationProcessor methods be &mut self.
emilio Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/style/data.rs
View file
Open in desktop
Expand Up @@ -244,6 +244,7 @@ impl ElementData {
return InvalidationResult::empty();
}

use invalidation::element::collector::StateAndAttrInvalidationProcessor;
use invalidation::element::invalidator::TreeStyleInvalidator;

debug!("invalidate_style_if_needed: {:?}, flags: {:?}, has_snapshot: {}, \
Expand All @@ -258,17 +259,21 @@ impl ElementData {
return InvalidationResult::empty();
}

let mut processor = StateAndAttrInvalidationProcessor;
let invalidator = TreeStyleInvalidator::new(
element,
Some(self),
shared_context,
stack_limit_checker,
nth_index_cache,
&mut processor,
);

let result = invalidator.invalidate();

unsafe { element.set_handled_snapshot() }
debug_assert!(element.handled_snapshot());

result
}

Expand Down