style: Use left-to-right indices in the invalidator. #18884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @heycam |
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 14, 2017
style: Use left-to-right indices in the invalidator. This will make easier to create external invalidations that don't point to a combinator, and also makes reasoning about the invalidator a bit easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18884) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
emilio
force-pushed
the
invalidator-ltr
branch
from
9fbf0cb
to
2819ba5
Compare
|
Rebased. @bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 15, 2017
style: Use left-to-right indices in the invalidator. This will make easier to create external invalidations that don't point to a combinator, and also makes reasoning about the invalidator a bit easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18884) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
heycam
approved these changes
Oct 16, 2017
components/selectors/parser.rs
Outdated
| @@ -442,10 +442,9 @@ impl<Impl: SelectorImpl> Selector<Impl> { | |||
|
|
|||
| /// Returns the combinator at index `index` (one-indexed from the right), | |||
There was a problem hiding this comment.
Should this now be "zero-indexed"?
components/selectors/parser.rs
Outdated
| @@ -460,16 +459,24 @@ impl<Impl: SelectorImpl> Selector<Impl> { | |||
| self.0.slice.iter() | |||
| } | |||
|
|
|||
| /// Returns the combinator at index `index` (one-indexed from the right), | |||
There was a problem hiding this comment.
Should this be "zero-indexed from the left"?
| debug_assert!(!dependency.affects_later_siblings()); | ||
| self.descendant_invalidations.push(Invalidation::new( | ||
| dependency.selector.clone(), | ||
| dependency.selector_offset, | ||
| dependency.selector.len() - dependency.selector_offset + 1, |
There was a problem hiding this comment.
Can you add a comment to Invalidation's offset field saying that it's a parse order offset?
This will make easier to create external invalidations, and also makes reasoning about the invalidator a bit easier.
emilio
force-pushed
the
invalidator-ltr
branch
from
2819ba5
to
f1cc225
Compare
|
@bors-servo r=heycam |
|
📌 Commit f1cc225 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 16, 2017
style: Use left-to-right indices in the invalidator. This will make easier to create external invalidations that don't point to a combinator, and also makes reasoning about the invalidator a bit easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18884) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make easier to create external invalidations that don't point to a combinator,
and also makes reasoning about the invalidator a bit easier.
This change is