Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) #19128

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) #19128

merged 1 commit into from
Nov 9, 2017

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 6, 2017 •
edited

This fixes some new warnings, some of which (in style) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726

This change is Reviewable

@highfive
Copy link

highfive commented Nov 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/pointing.mako.rs, components/style/values/specified/calc.rs, components/style/gecko/pseudo_element_definition.mako.rs, components/style/stylesheets/viewport_rule.rs, components/style/gecko/generated/pseudo_element_definition.rs and 18 more
  • @canaltinova: components/style/properties/longhand/pointing.mako.rs, components/style/values/specified/calc.rs, components/style/gecko/pseudo_element_definition.mako.rs, components/style/stylesheets/viewport_rule.rs, components/style/gecko/generated/pseudo_element_definition.rs and 16 more
  • @KiChjang: components/script/dom/textdecoder.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/servoparser/mod.rs, components/net_traits/response.rs, components/net_traits/response.rs and 19 more
  • @fitzgen: components/script/dom/textdecoder.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/servoparser/mod.rs, components/script/dom/window.rs, components/script/dom/blob.rs and 13 more
  • @emilio: components/style/properties/longhand/pointing.mako.rs, components/style/values/specified/calc.rs, components/style/gecko/pseudo_element_definition.mako.rs, components/style/stylesheets/viewport_rule.rs, components/style/gecko/generated/pseudo_element_definition.rs and 16 more

@highfive
Copy link

highfive commented Nov 6, 2017

warning Warning warning

  • These commits modify gfx, net, style, and script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 6, 2017
@nox
Copy link
Contributor

nox commented Nov 6, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7ca2bf1 has been approved by nox

@highfive highfive assigned nox and unassigned asajeffrey Nov 6, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 6, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7ca2bf1 with merge 58548a7...

bors-servo pushed a commit that referenced this pull request Nov 6, 2017
Auto merge of #19128 - servo:asciiext, r=nox
58548a7 
Upgrade to rustc 1.23.0-nightly (3b82e4c74 2017-11-05)

This fixes some new warnings, some of which (in `style`) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19128)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 6, 2017
@SimonSapin
Copy link
Member Author 

test cookie_http_state::test_0004 ... ok
error: An unknown error occurred

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, linux-dev, windows-msvc-dev are reusable. Rebuilding only arm32, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 6, 2017
@SimonSapin
Copy link
Member Author

I can reproduced this reliably on mac:

$ mach test-unit -p net -- --verbose -- --test-threads 1 test_0003
       Fresh bitflags v0.7.0
[…]
       Fresh net_tests v0.0.1 (file:///Users/simon/projects/servo/tests/unit/net)
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `/Users/simon/projects/servo/target/debug/deps/net_tests-77c63548d7be0fc1 --test-threads 1 test_0003`

running 1 test
test cookie_http_state::test_0003 ... error: process didn't exit successfully: `/Users/simon/projects/servo/target/debug/deps/net_tests-77c63548d7be0fc1 --test-threads 1 test_0003` (signal: 10, SIGBUS: access to undefined memory)

But not when running the binary directly:

target/debug/deps/net_tests-77c63548d7be0fc1 test_0003

running 1 test
test cookie_http_state::test_0003 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 419 filtered out

@SimonSapin
Copy link
Member Author

It turns out that using lldb over SSH is not allowed on OS X these day. Anyway, this test has #[should_panic] and it only fails when RUST_BACKTRACE=1 is set. Here is an lldb backtrace:

* thread #2, name = 'cookie_http_state::test_0003', stop reason = EXC_BAD_ACCESS (code=10, address=0x1019f2000)
  * frame #0: 0x000000010080c001 net_tests-77c63548d7be0fc1`macho_get_commands + 145
    frame #1: 0x000000010080d2cc net_tests-77c63548d7be0fc1`macho_try_dwarf + 396
    frame #2: 0x000000010080dd86 net_tests-77c63548d7be0fc1`macho_try_dsym + 726
    frame #3: 0x000000010080e319 net_tests-77c63548d7be0fc1`macho_add + 1225
    frame #4: 0x000000010080e507 net_tests-77c63548d7be0fc1`backtrace_initialize + 263
    frame #5: 0x000000010080b89e net_tests-77c63548d7be0fc1`fileline_initialize + 558
    frame #6: 0x000000010080b97d net_tests-77c63548d7be0fc1`backtrace_syminfo + 45
    frame #7: 0x00000001007f00e2 net_tests-77c63548d7be0fc1`core::slice::{{impl}}::position::{{closure}}<std::sys_common::backtrace::Frame,closure> [inlined] std::sys_common::gnu::libbacktrace::resolve_symname<closure> at libbacktrace.rs:79 [opt]
    frame #8: 0x00000001007f00af net_tests-77c63548d7be0fc1`core::slice::{{impl}}::position::{{closure}}<std::sys_common::backtrace::Frame,closure> [inlined] std::sys::imp::backtrace::printing::resolve_symname<closure> at mod.rs:36 [opt]
    frame #9: 0x00000001007f00af net_tests-77c63548d7be0fc1`core::slice::{{impl}}::position::{{closure}}<std::sys_common::backtrace::Frame,closure> [inlined] std::sys_common::backtrace::filter_frames::{{closure}} at backtrace.rs:108 [opt]
    frame #10: 0x00000001007f00a8 net_tests-77c63548d7be0fc1`core::slice::{{impl}}::position::{{closure}}<std::sys_common::backtrace::Frame,closure> at mod.rs:1204 [opt]
    frame #11: 0x00000001007fd781 net_tests-77c63548d7be0fc1`std::sys_common::backtrace::_print [inlined] core::slice::{{impl}}::search_while<std::sys_common::backtrace::Frame,core::option::Option<usize>,closure> at mod.rs:1271 [opt]
    frame #12: 0x00000001007fd73f net_tests-77c63548d7be0fc1`std::sys_common::backtrace::_print [inlined] core::slice::{{impl}}::position<std::sys_common::backtrace::Frame,closure> at mod.rs:1203 [opt]
    frame #13: 0x00000001007fd733 net_tests-77c63548d7be0fc1`std::sys_common::backtrace::_print [inlined] std::sys_common::backtrace::filter_frames at backtrace.rs:106 [opt]
    frame #14: 0x00000001007fd70f net_tests-77c63548d7be0fc1`std::sys_common::backtrace::_print at backtrace.rs:71 [opt]
    frame #15: 0x0000000100803ed4 net_tests-77c63548d7be0fc1`std::panicking::default_hook::{{closure}} [inlined] std::sys_common::backtrace::print at backtrace.rs:58 [opt]
    frame #16: 0x0000000100803eb3 net_tests-77c63548d7be0fc1`std::panicking::default_hook::{{closure}} at panicking.rs:381 [opt]
    frame #17: 0x0000000100803a23 net_tests-77c63548d7be0fc1`std::panicking::default_hook at panicking.rs:391 [opt]
    frame #18: 0x00000001008043b3 net_tests-77c63548d7be0fc1`std::panicking::rust_panic_with_hook at panicking.rs:577 [opt]
    frame #19: 0x000000010080422d net_tests-77c63548d7be0fc1`std::panicking::begin_panic<alloc::string::String> at panicking.rs:538 [opt]
    frame #20: 0x0000000100804183 net_tests-77c63548d7be0fc1`std::panicking::begin_panic_fmt at panicking.rs:522 [opt]
    frame #21: 0x00000001001ad22b net_tests-77c63548d7be0fc1`net_tests::cookie_http_state::test_0003::hffd4f07838948d71 + 443

The top frames look like https://github.com/rust-lang/rust/blob/master/src/libbacktrace/macho.c, and the only change to that in this interval of Rust versions is rust-lang/rust#45523.

@SimonSapin
Copy link
Member Author

Bad news: I can also reproduce on master.

@SimonSapin
Copy link
Member Author

This is likely rust-lang/rust#45731

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #19038) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Nov 6, 2017
@SimonSapin
Copy link
Member Author

I can also reproduce on master.

It’s more subtle than that. After observing the failure if I downgrade the compiler to a normally not-affected version I’ll still see the same failure until I run cargo clean.

Anyway, some people over at rust-lang/rust#45731 seem to have a much better idea than me of what’s going on, so let’s wait for a fix upstream.

@bors-servo
Copy link
Contributor

🔒 Merge conflict

1 similar comment
@bors-servo
Copy link
Contributor

🔒 Merge conflict

emilio added a commit to emilio/servo that referenced this pull request Nov 9, 2017
@emilio
Allow unused imports for AsciiExt in style code.
e640aaf 
See servo#19128, this part is cherry-picked so Gecko can build with rust nightly.
emilio pushed a commit to emilio/servo that referenced this pull request Nov 9, 2017
@SimonSapin @emilio
Allow unused imports for AsciiExt in style code.
ff3af47 
See servo#19128, this part is cherry-picked so Gecko can build with rust nightly.
bors-servo pushed a commit that referenced this pull request Nov 9, 2017
Auto merge of #19162 - emilio:ascii-ext, r=emilio
9539662 
Allow unused imports for AsciiExt in style code.

See #19128, this part is cherry-picked so Gecko can build with rust nightly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19162)
<!-- Reviewable:end -->
emilio pushed a commit to emilio/servo that referenced this pull request Nov 9, 2017
@SimonSapin @emilio
Allow unused imports for AsciiExt in style code.
66c3de6 
See servo#19128, this part is cherry-picked so Gecko can build with rust nightly.
bors-servo pushed a commit that referenced this pull request Nov 9, 2017
Auto merge of #19162 - emilio:ascii-ext, r=emilio
ff8efe2 
Allow unused imports for AsciiExt in style code.

See #19128, this part is cherry-picked so Gecko can build with rust nightly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19162)
<!-- Reviewable:end -->
emilio pushed a commit to emilio/servo that referenced this pull request Nov 9, 2017
@SimonSapin @emilio
Allow unused imports for AsciiExt in style code.
954b2cc 
See servo#19128, this part is cherry-picked so Gecko can build with rust nightly.
bors-servo pushed a commit that referenced this pull request Nov 9, 2017
Auto merge of #19162 - emilio:ascii-ext, r=emilio
e7a654d 
Allow unused imports for AsciiExt in style code.

See #19128, this part is cherry-picked so Gecko can build with rust nightly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19162)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 9, 2017
@nox nox changed the title Upgrade to rustc 1.23.0-nightly (3b82e4c74 2017-11-05) Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) Nov 9, 2017
@nox nox removed the S-needs-rebase There are merge conflict errors. label Nov 9, 2017
@nox
Copy link
Contributor

nox commented Nov 9, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 793bebf has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 9, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 793bebf with merge e0d2c8e...

bors-servo pushed a commit that referenced this pull request Nov 9, 2017
Auto merge of #19128 - servo:asciiext, r=nox
e0d2c8e 
Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08)

This fixes some new warnings, some of which (in `style`) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19128)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 9, 2017
@nox
Copy link
Contributor

nox commented Nov 9, 2017

That seems like a network issue, file https://s3.amazonaws.com/rust-lang-ci/rustc-builds-alt/02004ef78383cb174a41df7735a552823fa10b90/rustc-nightly-x86_64-unknown-linux-gnu.tar.gz definitely is downloadable.

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 793bebf with merge c46c9dc...

bors-servo pushed a commit that referenced this pull request Nov 9, 2017
Auto merge of #19128 - servo:asciiext, r=nox
c46c9dc 
Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08)

This fixes some new warnings, some of which (in `style`) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19128)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 9, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing c46c9dc to master...

@bors-servo bors-servo merged commit 793bebf into master Nov 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 9, 2017
@nox nox deleted the asciiext branch November 9, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SimonSapin @highfive @nox @bors-servo @asajeffrey