Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to share style on quirks mode whenever two elements have different id #19429

Merged
merged 1 commit into from Nov 30, 2017
Merged

Don't try to share style on quirks mode whenever two elements have different id #19429

merged 1 commit into from Nov 30, 2017

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Nov 30, 2017 •
edited by SimonSapin

This fixes bug 1420946.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 30, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@upsuper
Copy link
Contributor Author

upsuper commented Nov 30, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit af8026a has been approved by emilio

@highfive highfive assigned emilio and unassigned cbrewster Nov 30, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit af8026a with merge 67ced71...

bors-servo pushed a commit that referenced this pull request Nov 30, 2017
Auto merge of #19429 - upsuper:sharing-quirks-id, r=emilio
67ced71 
Don't try to share style on quirks mode whenever two elements have different id

This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 30, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Nov 30, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 30, 2017
@upsuper
Copy link
Contributor Author

upsuper commented Nov 30, 2017

Interesting... looks like this fixes tons of wpt in servo... How can this happen?

@emilio
Copy link
Member

emilio commented Nov 30, 2017

That's surprising, specially because most of those tests don't even have elements with id attributes...

@emilio
Copy link
Member

emilio commented Nov 30, 2017

@bors-servo retry

@emilio
Copy link
Member

emilio commented Nov 30, 2017

I'll investigate a bit locally.

@emilio
Copy link
Member

emilio commented Nov 30, 2017

The tests definitely do not pass locally, I cannot make any sense of that failure.

bors-servo pushed a commit that referenced this pull request Nov 30, 2017
Auto merge of #19429 - upsuper:sharing-quirks-id, r=emilio
fce44a2 
Don't try to share style on quirks mode whenever two elements have different id

This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19429)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit af8026a with merge fce44a2...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 30, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing fce44a2 to master...

@bors-servo bors-servo merged commit af8026a into servo:master Nov 30, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 30, 2017
@upsuper upsuper deleted the sharing-quirks-id branch November 30, 2017 15:33
@emilio emilio mentioned this pull request Dec 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@upsuper @highfive @bors-servo @emilio @cbrewster