Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to share style on quirks mode whenever two elements have different id #19429

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
5 participants
@upsuper
Copy link
Member

commented Nov 30, 2017

This fixes bug 1420946.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Nov 30, 2017

Heads up! This PR modifies the following files:

@highfive

This comment has been minimized.

Copy link

commented Nov 30, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

📌 Commit af8026a has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

⌛️ Testing commit af8026a with merge 67ced71...

bors-servo added a commit that referenced this pull request Nov 30, 2017

Auto merge of #19429 - upsuper:sharing-quirks-id, r=emilio
Don't try to share style on quirks mode whenever two elements have different id

This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19429)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

💔 Test failed - linux-rel-wpt

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

💔 Test failed - linux-rel-wpt

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

Interesting... looks like this fixes tons of wpt in servo... How can this happen?

@emilio

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

That's surprising, specially because most of those tests don't even have elements with id attributes...

@emilio

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

@bors-servo retry

@emilio

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

I'll investigate a bit locally.

@emilio

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

The tests definitely do not pass locally, I cannot make any sense of that failure.

bors-servo added a commit that referenced this pull request Nov 30, 2017

Auto merge of #19429 - upsuper:sharing-quirks-id, r=emilio
Don't try to share style on quirks mode whenever two elements have different id

This fixes [bug 1420946](https://bugzilla.mozilla.org/show_bug.cgi?id=1420946).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19429)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

⌛️ Testing commit af8026a with merge fce44a2...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

@bors-servo bors-servo merged commit af8026a into servo:master Nov 30, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@upsuper upsuper deleted the upsuper:sharing-quirks-id branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.