Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Remove the grid pref. #19584

Merged
merged 1 commit into from
Dec 16, 2017
Merged

style: Remove the grid pref. #19584

merged 1 commit into from
Dec 16, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Dec 16, 2017 •
edited by SimonSapin

Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze

This change is Reviewable

@emilio
style: Remove the grid pref.
af3a50a 
Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs, components/style/properties/shorthand/position.mako.rs
  • @canaltinova: components/style/properties/longhand/position.mako.rs, components/style/properties/shorthand/position.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 16, 2017
@emilio
Copy link
Member Author

emilio commented Dec 16, 2017

@bors-servo r=mats p=1

@bors-servo
Copy link
Contributor

📌 Commit af3a50a has been approved by mats

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 16, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit af3a50a with merge 1501a41...

bors-servo pushed a commit that referenced this pull request Dec 16, 2017
Auto merge of #19584 - emilio:remove-grid-pref, r=mats
1501a41 
style: Remove the grid pref.

Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19584)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: mats
Pushing 1501a41 to master...

@bors-servo bors-servo merged commit af3a50a into servo:master Dec 16, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 16, 2017
@bors-servo bors-servo mentioned this pull request Dec 16, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilio @highfive @bors-servo @KiChjang