style: Move most of allowed_in to NonCustomPropertyId. #20046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
|
r? @nox |
|
@bors-servo r+ |
|
📌 Commit c53016a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2018
style: Move most of allowed_in to NonCustomPropertyId. Also simplify the servo property id to gecko property id conversion to be faster and less repetitive. This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something that we don't contemplate right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20046) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
error[E0425]: cannot find value `id` in this scope
--> /home/servo/buildbot/slave/linux-rel-wpt/build/target/release/build/style-4b63d270e8e82720/out/properties.rs:51080:44
|
51080 | let pref = match PREF_NAME[id.0] {
| ^^ not found in this scope
help: possible candidate is found in another module, you can import it into scope
|
14 | use std::process::id;
|
error: aborting due to previous error
error: Could not compile `style`. |
Also simplify the servo property id to gecko property id conversion to be faster and less repetitive.
highfive
added
S-awaiting-review
|
@bors-servo r=nox |
|
📌 Commit 1548520 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2018
style: Move most of allowed_in to NonCustomPropertyId. Also simplify the servo property id to gecko property id conversion to be faster and less repetitive. This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something that we don't contemplate right now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20046) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify the servo property id to gecko property id conversion to be faster
and less repetitive.
This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something that we don't contemplate right now.
This change is