Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Fix text-emphasis-style conversion. #20186

Merged
merged 1 commit into from Mar 3, 2018
Merged

style: Fix text-emphasis-style conversion. #20186

merged 1 commit into from Mar 3, 2018

Conversation

emilio
Copy link
Member

@emilio emilio commented Mar 3, 2018 •
edited by SimonSapin

Was accidentally broken in #20178 and is causing orange.

This change is Reviewable

@emilio
style: Fix text-emphasis-style conversion.
569dde7 
Was accidentally broken in servo#20178 and is causing orange.
@highfive
Copy link

highfive commented Mar 3, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs
  • @canaltinova: components/style/properties/gecko.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 3, 2018
@highfive
Copy link

highfive commented Mar 3, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Mar 3, 2018

r? @nox

@highfive highfive assigned nox and unassigned cbrewster Mar 3, 2018
@nox
Copy link
Contributor

nox commented Mar 3, 2018

@bors-servo r+ p=10

NO ORANGE ALLOWED

@bors-servo
Copy link
Contributor

📌 Commit 569dde7 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 3, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 569dde7 with merge 2425939...

bors-servo pushed a commit that referenced this pull request Mar 3, 2018
Auto merge of #20186 - emilio:fixup-fill, r=nox
2425939 
style: Fix text-emphasis-style conversion.

Was accidentally broken in #20178 and is causing orange.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20186)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 2425939 to master...

@bors-servo bors-servo merged commit 569dde7 into servo:master Mar 3, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @nox @bors-servo @cbrewster