Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of block axis for abspos elements in Layout 2020 #29631

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/layout_2020/positioned.rs
Expand Up @@ -458,8 +458,7 @@ impl HoistedAbsolutelyPositionedBox {
};
let solve_block_axis = |computed_size| {
solve_axis(
// TODO(delan) shouldn’t this be cbbs?
cbis,
cbbs,
pbm.padding_border_sums.block,
pbm.margin.block_start,
pbm.margin.block_end,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

@@ -1,16 +1,4 @@
[position-absolute-dynamic-containing-block.html]
[abs containing block moves from outer to intermediate]
expected: FAIL

[abs containing block moves from intermediate to outer]
expected: FAIL

[target is no longer absolute]
expected: FAIL

[target becomes absolute]
expected: FAIL

[fixed containing block moves from outer to intermediate]
expected: FAIL

Expand Down
@@ -0,0 +1,2 @@
[position-absolute-fit-content.html]
expected: FAIL