Reorganize Servo's WPT Python scripts #29639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
reorganize-wpt-python
branch
2 times, most recently
from
347b362
to
0b0d284
Compare
mukilan
reviewed
Apr 19, 2023
| import os | ||
| import sys | ||
|
|
||
| from .tree import GitTree, GeckoCommit |
There was a problem hiding this comment.
Just curious if there is any particular reason for retaining the 'gecko' terminology in this file (I see few more references to gecko in doc strings below).
There was a problem hiding this comment.
That's a good question. My thought was to only move the scripts now and then gradually start cleaning them up later. There are also some things that could be shared between the importer and exporter, once these two scripts are in the same module.
mrobinson
force-pushed
the
reorganize-wpt-python
branch
from
0b0d284
to
1abee12
Compare
This change moves all of Servo's WPT Python support scripts into one
directory as they were previously scattered throughout the directory
structure. This should allow more code reuse and make it easier to
understand how everything fits together.
The changes:
- `tests/wpt/update` → `python/wpt/importer`
- `etc/ci/upstream-wpt-changes/wptupstreamer` → `python/wpt/exporter`
- `etc/ci/upstream-wpt-changes/test.py` → `python/wpt/test.py`
- `etc/ci/upstream-wpt-changes/tests` → `python/wpt/tests`
- `tests/wpt/servowpt.py` →
- `python/wpt/update.py`
- `python/wpt/run.py`
- `tests/wpt/manifestupdate.py` → `python/wpt/manifestupdate.py`
This change also removes
- The ability to run the `update-wpt` and `test-wpt` commands without
using `mach`. These didn't work very well, because it was difficult
to get all of the wptrunner and mach dependencies installed outside
of the Python virtualenv. It's simpler if they are always run through
`mach`.
- The old WPT change upstreaming script that was no longer used.
mrobinson
force-pushed
the
reorganize-wpt-python
branch
from
1abee12
to
e2cf3e8
Compare
mukilan
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Nice refactoring! Thank you for the walkthrough, @mrobinson !
|
@bors-servo r=mukilan |
|
📌 Commit e2cf3e8 has been approved by |
|
Thank you for the review! |
|
@bors-servo ping |
|
😪 I'm awake I'm awake |
|
💥 Test timed out |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Apr 21, 2023
Reorganize Servo's WPT Python scripts This change moves all of Servo's WPT Python support scripts into one directory as they were previously scattered throughout the directory structure. This should allow more code reuse and make it easier to understand how everything fits together. The changes: - `tests/wpt/update` → `python/wpt/importer` - `etc/ci/upstream-wpt-changes/wptupstreamer` → `python/wpt/exporter` - `etc/ci/upstream-wpt-changes/test.py` → `python/wpt/test.py` - `etc/ci/upstream-wpt-changes/tests` → `python/wpt/tests` - `tests/wpt/servowpt.py` → - `python/wpt/update.py` - `python/wpt/run.py` - `tests/wpt/manifestupdate.py` → `python/wpt/manifestupdate.py` This change also removes - The ability to run the `update-wpt` and `test-wpt` commands without using `mach`. These didn't work very well, because it was difficult to get all of the wptrunner and mach dependencies installed outside of the Python virtualenv. It's simpler if they are always run through `mach`. - The old WPT change sync / upstreaming script that was no longer used. This allows this code to pass `test-tidy` now. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Results from try job (#4762390522): Flaky unexpected result (25)
Stable unexpected results that are known to be intermittent (19)
|
|
💔 Test failed - checks-github |
|
@bors-servo retry |
5 tasks
|
Results from try job (#4778278795): Flaky unexpected result (21)
Stable unexpected results that are known to be intermittent (22)
|
|
☀️ Test successful - checks-github |
1 similar comment
|
☀️ Test successful - checks-github |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all of Servo's WPT Python support scripts into one directory as they were previously scattered throughout the directory structure. This should allow more code reuse and make it easier to understand how everything fits together.
The changes:
tests/wpt/update→python/wpt/importeretc/ci/upstream-wpt-changes/wptupstreamer→python/wpt/exporteretc/ci/upstream-wpt-changes/test.py→python/wpt/test.pyetc/ci/upstream-wpt-changes/tests→python/wpt/teststests/wpt/servowpt.py→ -python/wpt/update.py-python/wpt/run.pytests/wpt/manifestupdate.py→python/wpt/manifestupdate.pyThis change also removes
update-wptandtest-wptcommands without usingmach. These didn't work very well, because it was difficult to get all of the wptrunner and mach dependencies installed outside of the Python virtualenv. It's simpler if they are always run throughmach.test-tidynow../mach build -ddoes not report any errors./mach test-tidydoes not report any errors