Do not use the CB writing mode when resolving box properties #29651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout 2020 does a lot of work to pass the containing block writing mode around in order to try to resolve logical box properties. This seems incorrect though, as logical box model properties use the element's writing mode to resolve to physical properties [1] [2]. This is handled correctly by the style component, but Layout 2020 does a lot of work to try to override them. This change removes that code and also tries to use more style component data structures in place of Layout 2020's custom logical geometry primitives. In particular it removes the confusingly overloaded type aliases `LengthOrAuto` and `LengthPercentageOrAuto` from Layout 2020. These aliases were very similar to the ones from the style component, but had a different definition. Since Layout 2020 does not have proper support for writing modes, this change should not modify behavior. 1. w3c/csswg-drafts#3013 2. https://drafts.csswg.org/css-logical/#box
mrobinson
added
the
A-layout/2020
|
After discussing with @Loirooriol, it seems that I was mistaken here. While the logical values should be resolved based on their element's writing mode, these physical values need to them be converted back to inline and block directions in the coordinate space of the containing block. There's some work from this PR that can be salvaged, particularly removing the duped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout 2020 does a lot of work to pass the containing block writing mode around in order to try to resolve logical box properties. This seems incorrect though, as logical box model properties use the element's writing mode to resolve to physical properties [1] [2]. This is handled correctly by the style component, but Layout 2020 does a lot of work to try to override them.
This change removes that code and also tries to use more style component data structures in place of Layout 2020's custom logical geometry primitives. In particular it removes the confusingly overloaded type aliases
LengthOrAutoandLengthPercentageOrAutofrom Layout 2020. These aliases were very similar to the ones from the style component, but had a different definition.Since Layout 2020 does not have proper support for writing modes, this change should not modify behavior.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors