New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto wpt option to workflow #29673
base: main
Are you sure you want to change the base?
Conversation
Thank you for doing this work. We've talked this and we feel like since we are doing a lot more effort on Layout 2020, we would like to always run the WPT suite in the main workflow for Layout 2020. See #29746. |
The only change that was needed was setting layout2013 to auto and layout2020 to test, if we still want to have any tests running for layout2013. I also updated PR description. |
Apologies, I was not super clear in my last comment. For now, we'd like to try running WPT for both layout 2013 and layout 2020 in the main workflow. |
I will keep this PR open, so when it is decided not to run layout2013 wpt tests anymore, this can be merged, to keep layout2013 in shape until, it gets completely removed. |
☔ The latest upstream changes (presumably #29866) made this pull request unmergeable. Please resolve the merge conflicts. |
I've been thinking a bit more about this and it's a really tricky change. Here are some examples of why:
I think the number directories that we can change without wanting to run WPT tests are actually quite small. I do not know if it's possible to detect this as Servo currently is. Perhaps we could skip certain platforms if we only modify platform-specific code...but I'm not certain even that is possible. |
Auto option wasn't meant to be used on layout2020, it is meant to provide best-effort CI runs for layout2013, when we want to deprecate layout2013 even further, kicking it out of main CI, but not removing from tree. |
This would first require switching the main bulk of tests over to be run via layout 2020. Is the idea that this would run as the main workflow or that people would use a try=auto option? |
This was planned to be run as part of main workflow. try=wpt would still run layout2013 no matter what. Given the recent changes we could also make parameter for normal try build to force layout2013 wpt test. |
I think we must always run all WPT tests when landing changes, but perhaps try could skip jobs. |
Introduces auto wpt option in Linux workflow, which runs wpt test for layout-engine based on file changes.
So now we have 3 wpt options:
test
unconditionally runs wpt testsauto
runs wpt tests only if there are changes in layout folders (does are determined by filters based on selected layout)sync
unconditionally runs wpt tests and sync themIn main workflow layout2020 is in
test
mode (run on every change), layout2013 is inauto
mode (wpt test are run only if changes are present in layout2013 folders), othertry-*
builds would still be working as expected.