Add value argument to URLSearchParams's has() and delete() #29726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
requested changes
May 9, 2023
Comment on lines
146
to
148
| list.iter().any(|&(ref k, ref v)| { | ||
| if let Some(value) = &value { | ||
| k == &name.0 && v == &value.0 | ||
| } else { | ||
| k == &name.0 | ||
| } | ||
| }) |
There was a problem hiding this comment.
I think this could be rewritten as a match statement:
match &value {
Some(value) => k == &name.0 && v == &value.0
None => k == &name.0
}| // Step 1. | ||
| self.list.borrow_mut().retain(|&(ref k, _)| k != &name.0); | ||
| self.list.borrow_mut().retain(|&(ref k, ref v)| { |
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
May 9, 2023
Add value argument to URLSearchParams's has() and delete() <!-- Please describe your changes on the following line: --> My first attempt at contributing Rust code! Add the value argument to `has()` and `done()` as in [the spec](https://url.spec.whatwg.org/#dom-urlsearchparams-delete). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29725 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
I suspect you will also need to update results for Layout 2020. |
|
Test results for linux-wpt-layout-2020 from try job (#4923384275): Stable unexpected results that are known to be intermittent (1)
|
|
☀️ Test successful - checks-github |
|
Okay, it should be fixed-up now |
This commit should fix servo#29725. Signed-off-by: Veronika Bušů <paricbat@email.cz>
mrobinson
force-pushed
the
urlsearchparams-has-delete
branch
from
410e0b3
to
e40ec79
Compare
mrobinson
approved these changes
May 11, 2023
|
@bors-servo r+ |
|
📌 Commit e40ec79 has been approved by |
|
Test results for linux-wpt-layout-2013 from try job (#4944752906): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (13)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at contributing Rust code!
Add the value argument to
has()anddone()as in the spec../mach build -ddoes not report any errors./mach test-tidydoes not report any errors