Stop skipping css-logical tests in layout-2020 #29814

Loirooriol · 2023-05-30T14:31:10Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #___ (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because there is no change in behavior

Loirooriol · 2023-05-30T14:37:10Z

@bors-servo try=wpt-2020

bors-servo · 2023-05-30T14:37:14Z

⌛ Trying commit c1a9ff0 with merge 266b288...

Stop skipping css-logical tests in layout-2020  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [X] These changes do not require tests because there is no change in behavior

Loirooriol · 2023-05-30T14:39:02Z

I expected less failures TBH, since this should mostly be a style thing.

mrobinson · 2023-05-30T14:49:41Z

It could be that some of these properties are disabled since Layout 2020 doesn't support writing modes.

Loirooriol · 2023-05-30T14:54:41Z

Ah, that explains it. Most of the logical longhands seem enabled, but if writing modes aren't supported, they will not be mapped as the tests expect.

github-actions · 2023-05-30T15:23:44Z

Test results for linux-wpt-layout-2020 from try job (#5122849423):

Flaky unexpected result (1)

TIMEOUT [expected PASS] /css/css-color/animation/opacity-animation-ending-correctly-001.html (#29215)

bors-servo · 2023-05-30T15:23:57Z

☀️ Test successful - checks-github
State: approved= try=True

Loirooriol · 2023-05-30T15:24:55Z

@bors-servo r=mrobinson

bors-servo · 2023-05-30T15:24:57Z

📌 Commit c1a9ff0 has been approved by mrobinson

bors-servo · 2023-05-30T15:25:00Z

⌛ Testing commit c1a9ff0 with merge 39a2c23...

Stop skipping css-logical tests in layout-2020  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [X] These changes do not require tests because there is no change in behavior

github-actions · 2023-05-30T15:59:52Z

Test results for linux-wpt-layout-2020 from try job (#5123356858):

Flaky unexpected result (1)

OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
- FAIL [expected PASS] subtest: Throttling the performance timeline task queue. assert_true: expected true got false

github-actions · 2023-05-30T16:24:55Z

Test results for linux-wpt-layout-2013 from try job (#5123356858):

Flaky unexpected result (14)

TIMEOUT [expected OK] /FileAPI/url/url-charset.window.html (#26997)
- TIMEOUT [expected PASS] subtest: Blob charset should override any auto-detected charset. Test timed out
TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works. Test timed out
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK [expected TIMEOUT] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/failure-check-sequence.https.html (#28207)
- TIMEOUT [expected FAIL] subtest: CSP check precedes X-Frame-Options check Test timed out
- NOTRUN [expected FAIL] subtest: CSP check precedes COEP check - CSP header first
- NOTRUN [expected FAIL] subtest: CSP check precedes COEP check - COEP header first
- NOTRUN [expected FAIL] subtest: COEP check precedes X-Frame-Options check
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/skip-another-top-level-browsing-context.html (#24161)
- TIMEOUT [expected PASS] subtest: Autofocus elements queued in another top-level browsing context's documents should be skipped. Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
ERROR [expected OK] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)
- FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler assert_array_equals: expected property 1 to be "Script Create azure bindings for Rust #1 ran" but got "Script Handle "close window" event and interrupt signal #3 ran" (expected array ["Script Fix out-of-tree builds #2 ran", "Script Create azure bindings for Rust #1 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran"] got ["Script Fix out-of-tree builds #2 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran", "Script Create azure bindings for Rust #1 ran"])
TIMEOUT [expected OK] /webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html (#21743)
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (18)

OK [expected TIMEOUT] /fetch/local-network-access/iframe.tentative.https.window.html (#29605)
- FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: failure. timeout adding grandchild
- FAIL [expected TIMEOUT] subtest: public to local, grandparent navigates: success. timeout adding grandchild
OK /fetch/local-network-access/worker-blob-fetch.window.html (#29602)
- FAIL [expected PASS] subtest: local https to local https: success. assert_equals: fetch error expected (undefined) undefined but got (string) "unknown error"
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent) Test timed out
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
TIMEOUT [expected OK] /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- TIMEOUT [expected PASS] subtest: first argument: absolute url Test timed out
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...).show is not a function"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus assert_equals: expected "SPAN" but got "BODY"
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus assert_equals: expected Element node <area></area> but got Element node <body>
  <img src="/media/poster.png" usemap="#map">
  <map n...
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- FAIL [expected TIMEOUT] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks w.focus is not a function
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- PASS [expected FAIL] subtest: Video should seek to time specified in media fragment syntax
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
OK [expected TIMEOUT] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /workers/dedicated-worker-from-blob-url.window.html (#22286)
- FAIL [expected PASS] subtest: Creating a dedicated worker from a blob URL works immediately before revoking. promise_test: Unhandled rejection with value: object "[object Event]"

Stable unexpected results (1)

TIMEOUT /html/canvas/offscreen/pixel-manipulation/2d.imageData.get.large.crash.html
- FAIL [expected TIMEOUT] subtest: Test that canvas crash when image data cannot be allocated. assert_throws_js: function "function() { ctx.getImageData(10, 0xffffffff, 2147483647, 10); }" threw object "IndexSizeError: The index is not in the allowed range." ("IndexSizeError") expected instance of function "function TypeError() {
  [native code]
  }" ("TypeError")

bors-servo · 2023-05-30T17:47:05Z

💔 Test failed - checks-github

Loirooriol · 2023-05-30T17:56:19Z

@bors-servo retry

bors-servo · 2023-05-30T17:56:22Z

⌛ Testing commit c1a9ff0 with merge 4e1d3a8...

github-actions · 2023-05-30T19:02:52Z

Test results for linux-wpt-layout-2013 from try job (#5124719386):

Flaky unexpected result (12)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html (#28716)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by formElement.requestSubmit() Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html (#26371)
- TIMEOUT [expected FAIL] subtest: delayed handling: delaying handling rejected promise created from createImageBitmap will cause both events to fire Test timed out
TIMEOUT /resource-timing/response-status-code.html (#29309)
- TIMEOUT [expected FAIL] subtest: This test validates the response status of resources. 88 Test timed out
- NOTRUN [expected TIMEOUT] subtest: This test validates the response status of resources. 89
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results that are known to be intermittent (22)

OK [expected TIMEOUT] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
OK /fetch/local-network-access/worker-blob-fetch.window.html (#29602)
- FAIL [expected PASS] subtest: local https to local https: success. assert_equals: fetch error expected (undefined) undefined but got (string) "unknown error"
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK [expected TIMEOUT] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
- PASS [expected TIMEOUT] subtest: Traversing the history during unload
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...).show is not a function"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus assert_equals: expected "SPAN" but got "BODY"
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- FAIL [expected TIMEOUT] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks w.focus is not a function
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- PASS [expected FAIL] subtest: Video should seek to time specified in media fragment syntax
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- FAIL [expected PASS] subtest: The end: DOMContentLoaded and defer scripts assert_false: DOMContentLoaded should not have fired before executing a task queued from a defer script expected false got true
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- PASS [expected FAIL] subtest: document.write in an imported module
TIMEOUT /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- FAIL [expected TIMEOUT] subtest: Sanity check: this all works as expected with no promises involved assert_equals: expected "http://web-platform.test:8000/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/resources/window-to-open.html" but got "about:blank"
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)
OK /workers/dedicated-worker-from-blob-url.window.html (#22286)
- FAIL [expected PASS] subtest: Creating a dedicated worker from a blob URL works immediately before revoking. promise_test: Unhandled rejection with value: object "[object Event]"

bors-servo · 2023-05-30T20:17:21Z

☀️ Test successful - checks-github
Approved by: mrobinson
Pushing 4e1d3a8 to master...

Stop skipping css-logical tests in layout-2020

c1a9ff0

mrobinson approved these changes May 30, 2023

View reviewed changes

bors-servo merged commit 4e1d3a8 into servo:master May 30, 2023
10 checks passed

Loirooriol deleted the do-not-skip-css-logical branch May 30, 2023 23:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop skipping css-logical tests in layout-2020 #29814

Stop skipping css-logical tests in layout-2020 #29814

Loirooriol commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

mrobinson commented May 30, 2023

Loirooriol commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

bors-servo commented May 30, 2023

github-actions bot commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023

Stop skipping css-logical tests in layout-2020 #29814

Stop skipping css-logical tests in layout-2020 #29814

Conversation

Loirooriol commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

mrobinson commented May 30, 2023

Loirooriol commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

bors-servo commented May 30, 2023

github-actions bot commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023

Loirooriol commented May 30, 2023

bors-servo commented May 30, 2023

github-actions bot commented May 30, 2023

bors-servo commented May 30, 2023