Clear PositioningContext for speculative layouts #29835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`try_layout` is used for laying out absolutely positioned
descendants multiple times when min/max-{width, height}
properties are set. When the same PositioningContext instance
is used between successive attempts without clearing the accumulated
descendants, we will generate multiple fragments which reference
the same box, which then will lead to a double borrow error
when layout is performed in parallel.
Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
mukilan
force-pushed
the
fix-double-borrow-in-hoisted
branch
from
5d9c808
to
7ead24a
Compare
|
@bors-servo r+ |
|
📌 Commit 7ead24a has been approved by |
|
Test results for linux-wpt-layout-2020 from try job (#5161694252): Stable unexpected results that are known to be intermittent (1)
|
|
Test results for linux-wpt-layout-2013 from try job (#5161694252): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (21)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed in collaboration with @mrobinson
try_layoutis used for laying out absolutely positioned descendants multiple times when min/max-{width, height} properties are set. When the same PositioningContext instance is used between successive attempts without clearing the accumulated descendants, we will generate multiple fragments which reference the same box, which then will lead to a double borrow error when layout is performed in parallel../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsmach test-wptto make crash tests work #29832 is fixed.