Fix compile on Fedora 38 (cargo upgrade mozangle to v0.3.4) #29879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was unable to compile the servo/servo main branch. The fix for the compile error was already provided with servo/mozangle v0.3.4. The Cargo.lock file locked the version to v0.3.3. The changeset upgrades the Cargo.lock file to use mozangle v0.3.4. This also requires to upgrade the 'cc' dependency to v1.0.79. After applying these changes my Fedora 38 box builds the servo debug binary successfully. Signed-off-by: Marco Schmidt <marco.schmidt@taugamma.eu>
|
Can you also try running |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 15, 2023
…st, r=<try> Fix compile on Fedora 38 (cargo upgrade mozangle to v0.3.4) The changeset upgrades the Cargo.lock file to use mozangle v0.3.4. This also requires to upgrade the 'cc' dependency to v1.0.79. I was unable to compile the servo/servo main branch. The fix for the compile error was already provided with servo/mozangle v0.3.4. The Cargo.lock file locked the version to v0.3.3. After applying these changes my Fedora 38 box builds the servo debug binary successfully. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it solves a build issue. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Just like #29849 this change breaks |
|
💥 Test timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset upgrades the Cargo.lock file to use mozangle v0.3.4. This also requires to upgrade the 'cc' dependency to v1.0.79.
I was unable to compile the servo/servo main branch. The fix for the compile error was already provided with servo/mozangle v0.3.4. The Cargo.lock file locked the version to v0.3.3.
After applying these changes my Fedora 38 box builds the servo debug binary successfully.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors