Properly position floats when subsequent boxes collapse margins with containing block (2) #29945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2023
…gins-2, r=<try> Properly position floats when subsequent boxes collapse margins with containing block (2) PR #29939 tried to address this but missed various cases. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29944 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5406151740): Flaky unexpected result (1)
Stable unexpected results that are known to be intermittent (3)Stable unexpected results (1)
|
|
💔 Test failed - checks-github |
|
Test results for linux-wpt-layout-2020 from try job (#5406151740): Flaky unexpected result (1)
Stable unexpected results that are known to be intermittent (3)Stable unexpected results (1)
|
…containing block (2) PR servo#29939 tried to address this but missed various cases.
mrobinson
approved these changes
Jun 29, 2023
Loirooriol
force-pushed
the
fix-float-placement-with-future-margins-2
branch
from
020484f
to
a435e02
Compare
|
@bors-servo r=mrobinson Yes, I forgot to |
|
📌 Commit a435e02 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Jun 29, 2023
…gins-2, r=mrobinson Properly position floats when subsequent boxes collapse margins with containing block (2) PR #29939 tried to address this but missed various cases. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29944 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5410884625): Flaky unexpected result (11)
Stable unexpected results that are known to be intermittent (10)
|
|
💔 Test failed - checks-github |
|
@bors-servo retry Unit tests seem fine locally... |
|
BTW, if I apply a patch to fix clearance,
The yellow BFC should avoid the magenta and cyan floats and then force the green container to grow taller, like in Blink/WebKit:
Interestingly, Firefox is also failing:
|
4 tasks
|
@bors-servo r=mrobinson |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a435e02 has been approved by |
|
Test results for linux-wpt-layout-2020 from try job (#5418004623): |
|
Test results for linux-wpt-layout-2013 from try job (#5418004623): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (9)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #29939 tried to address this but missed various cases.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors