Windows bootstrap support #29954
Merged
Windows bootstrap support #29954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
windows-bootstrap
branch
2 times, most recently
from
d267bd1
to
6c6fdd2
Compare
4 tasks
mukilan
approved these changes
Jul 3, 2023
README.md
Outdated
| *This will install CMake, Git, LLVM, Ninja, NuGet, Python and the Visual Studio 2019 Build Tools.* | ||
| - Run `mach bootstrap-gstreamer` | ||
| - Run `mach bootstrap` | ||
| - *This will install CMake, Git, LLVM, Ninja, NuGet, Python and the Visual Studio 2019 Build Tools |
There was a problem hiding this comment.
Will LLVM be installed via choco as this comment suggests? I see we have removed it in choco.config
There was a problem hiding this comment.
Oh, nice catch. I've fixed this now.
mrobinson
force-pushed
the
windows-bootstrap
branch
from
6c6fdd2
to
633d9b0
Compare
|
@bors-servo r=mukilan |
|
📌 Commit 633d9b0 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Jul 3, 2023
Windows bootstrap support <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25224 - [x] These changes do not require tests because they are just support script changes. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5448040173): Stable unexpected results that are known to be intermittent (2) |
|
💔 Test failed - checks-github |
|
Test results for linux-wpt-layout-2020 from try job (#5449062109): Stable unexpected results that are known to be intermittent (2) |
|
Test results for linux-wpt-layout-2013 from try job (#5449062109): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (15)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors