Fix intrinsic sizing of block container containing a BFC root after floats #30012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2023
…ts, r=<try> Fix intrinsic sizing of block container containing a BFC root after floats A block that establishes an independent formatting context is placed next to previous floats, so we should add their sizes when computing the intrinsic contribution of the parent block container. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #30011 - [X] These changes do not require tests because the spec says "CSS 2 does not define the exact algorithm". <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
I had a full testcase at home that I can check when I get back, but I think this matches what other browser do. |
|
Test results for linux-wpt-layout-2020 from try job (#5595526567): Flaky unexpected result (2)Stable unexpected results that are known to be intermittent (1)
|
|
☔ The latest upstream changes (presumably 9c333ab) made this pull request unmergeable. Please resolve the merge conflicts. |
…loats A block that establishes an independent formatting context is placed next to previous floats, so we should add their sizes when computing the intrinsic contribution of the parent block container.
Loirooriol
force-pushed
the
fix-intrinsic-sizing-bfc-after-floats
branch
from
1f4459c
to
9e67a67
Compare
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2023
…ts, r=<try> Fix intrinsic sizing of block container containing a BFC root after floats A block that establishes an independent formatting context is placed next to previous floats, so we should add their sizes when computing the intrinsic contribution of the parent block container. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #30011 - [X] These changes do not require tests because the spec says "CSS 2 does not define the exact algorithm". <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5600521128): Flaky unexpected result (1)
Stable unexpected results that are known to be intermittent (1)
|
mrobinson
approved these changes
Jul 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
💥 Test timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A block that establishes an independent formatting context is placed
next to previous floats, so we should add their sizes when computing
the intrinsic contribution of the parent block container.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors