Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix try GitHub Action #30024

Merged
merged 1 commit into from Jul 25, 2023
Merged

Fix try GitHub Action #30024

merged 1 commit into from Jul 25, 2023

Conversation

mrobinson
Copy link
Member

@mrobinson mrobinson commented Jul 25, 2023 •
edited

  1. Properly handle multi-line comments
  2. Don't skip duplicate workflows when explicitly running try
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they fix a GitHub Action.

@mrobinson mrobinson requested a review from mukilan July 25, 2023 09:09
@mrobinson
Fixes for the try GitHub Action
35cf97c 
1. Properly handle multi-line comments
2. Don't skip duplicate workflows when explicitly running try
@mukilan mukilan added this pull request to the merge queue Jul 25, 2023
@mrobinson mrobinson changed the title Fix try GitHub Action for multi-line comments Fix try GitHub Action Jul 25, 2023
Merged via the queue into servo:master with commit f7fcc6e Jul 25, 2023
11 checks passed
@mrobinson mrobinson deleted the fix-try branch July 25, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukilan mukilan mukilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrobinson @mukilan