Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make return key equivalent to go button when location field is focused #30126

Merged
merged 2 commits into from Aug 29, 2023

Conversation

atbrakhi
Copy link
Member

@atbrakhi atbrakhi commented Aug 18, 2023

Adds Return key that is equivalent to go button when location field is focused in Minibrowser mode.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes part of [meta] Minibrowser #30049

@atbrakhi atbrakhi requested a review from delan August 18, 2023 11:52
@atbrakhi atbrakhi mentioned this pull request Aug 18, 2023
27 tasks
@delan
Copy link
Sponsor Member

delan commented Aug 21, 2023

This is a good start, though there are a couple parts of the behaviour I think we can improve:

  • the location sometimes reverts to the old value while loading, which may be confusing
  • we should also accept numpad enter, not just the normal return key

@atbrakhi
Copy link
Member Author

the location sometimes reverts to the old value while loading, which may be confusing

I will look into this part separately, as it is not the result of changes in this PR. I have added it as a TODO in #30049

we should also accept numpad enter, not just the normal return key

unfortunately egui does not have support for numpad enter. Docs here :(
I will add it as TODO in meta issue, so that we can check back later.

@delan delan changed the title Make enter/return key equivalent to go button when location field is focused Make return key equivalent to go button when location field is focused Aug 29, 2023
Copy link
Sponsor Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and good catch, I didn’t realise the location bug was pre-existing.

@servo-wpt-sync
Copy link
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@atbrakhi atbrakhi added this pull request to the merge queue Aug 29, 2023
Merged via the queue into servo:master with commit 2afb7c1 Aug 29, 2023
10 checks passed
@atbrakhi atbrakhi deleted the implement_enter_keypress branch August 29, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants