Flow inlines around floats #30243
Merged
Flow inlines around floats #30243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt-2020 |
|
🔨 Triggering try run (#6016041967) with platform=linux and layout=2020 |
|
Test results for linux-wpt-layout-2020 from try job (#6016041967): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (21)
|
|
|
3 tasks
mrobinson
force-pushed
the
float-inline
branch
2 times, most recently
from
69af0cf
to
d84344f
Compare
mrobinson
added
A-layout/2020
mrobinson
force-pushed
the
float-inline
branch
from
d84344f
to
2dfa9eb
Compare
|
@bors-servo try=wpt-2020 |
|
🔨 Triggering try run (#6025495747) with platform=linux and layout=2020 |
|
Test results for linux-wpt-layout-2020 from try job (#6025495747): Flaky unexpected result (11)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (1)
|
|
|
Loirooriol
force-pushed
the
float-inline
branch
2 times, most recently
from
844ef63
to
8e37e14
Compare
|
@bors-servo try=wpt-2020 |
|
🔨 Triggering try run (#6026279671) with platform=linux and layout=2020 |
|
I did some tweaks, mostly editorial, but also addressed a <!DOCTYPE html>
<div style="border: solid; width: 100px; text-indent: 0px; text-align: center">
<div style="float: left; width: 25px; height: 50px; background: magenta"></div>
<div style="display: inline-block; background: cyan; width: 30px; height: 50px"></div>
</div>
<div style="border: solid; width: 100px; text-indent: 20px; text-align: center">
<div style="float: left; width: 25px; height: 50px; background: magenta"></div>
<div style="display: inline-block; background: cyan; width: 30px; height: 50px"></div>
</div>
<div style="border: solid; width: 100px; text-indent: 45px; text-align: center">
<div style="float: left; width: 25px; height: 50px; background: magenta"></div>
<div style="display: inline-block; background: cyan; width: 30px; height: 50px"></div>
</div>
<div style="border: solid; width: 100px; text-indent: 46px; text-align: center">
<div style="float: left; width: 25px; height: 50px; background: magenta"></div>
<div style="display: inline-block; background: cyan; width: 30px; height: 50px"></div>
</div> |
|
Test results for linux-wpt-layout-2020 from try job (#6026279671): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (13)
|
|
✨ Try run (#6026279671) succeeded. |
This implements the rest of the bulk of float support. Now inline element flow around floats and floats can be pushed down by inline elements before them. Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
force-pushed
the
float-inline
branch
from
8e37e14
to
724f831
Compare
|
Thanks @Loirooriol. Your changes look good to me. If the change looks good to you now as well, feel free to r+ and merge. |
4 tasks
Loirooriol
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the rest of the bulk of float support. Now inline
elements flow around floats and floats can be pushed down by inline
elements before them.
Co-authored-by: Oriol Brufau obrufau@igalia.com
Fixes #29825.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors