[NFC] servoshell: fix euclid units associated with winit geometry #30344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delan
force-pushed
the
servoshell-dip-n-dp
branch
from
238baf9
to
b088f81
Compare
mrobinson
approved these changes
Sep 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headed Window::get_coordinates multiplies screen sizes, window sizes, and window positions by a fake dip-to-dp scale factor to work around the fact that they were incorrectly marked as DeviceIndependentPixel, when winit’s PhysicalSize and PhysicalPosition types should actually be in DevicePixel.
This patch fixes those units and adds helper functions for converting winit types to euclid types, making our geometry calculations simpler and eliminating almost all of the untyped operations.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors