Enable new color functions from CSS Color 4 #30752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#6916285151) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2020 from try job (#6916285151): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (108)
|
|
|
Loirooriol
force-pushed
the
enable-new-color
branch
from
9d726c3
to
db95097
Compare
|
🔨 Triggering try run (#6916606411) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2013 from try job (#6916606411): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (109)
|
|
Test results for linux-wpt-layout-2020 from try job (#6916606411): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (108)
|
|
|
|
🔨 Triggering try run (#6917023360) with platforms=linux,macos,windows and layout=all |
|
Test results for linux-wpt-layout-2013 from try job (#6917023360): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (10)
|
|
Test results for linux-wpt-layout-2020 from try job (#6917023360): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#6917023360) succeeded. |
|
Instead of landing this as two changes, I think it makes sense to land it all together so that the earlier commits are contextualized by the newly passing tests. |
Loirooriol
force-pushed
the
enable-new-color
branch
from
359a893
to
bd935cb
Compare
I will need to do most of the work anyways during the style updates, so by enabling this it will be easier to detect mistakes. Also, canvas colors are now parsed as <color>, precisely to support these new features. This is according to the HTML spec: https://html.spec.whatwg.org/multipage/infrastructure.html#parsed-as-a-css-color-value
Loirooriol
force-pushed
the
enable-new-color
branch
from
bd935cb
to
35e4a1a
Compare
3 tasks
Loirooriol
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#6930574334) with platforms=linux and layout=all |
|
I have unified into a single commit, with some simplifications thanks to #30754. |
mrobinson
approved these changes
Nov 20, 2023
|
Test results for linux-wpt-layout-2013 from try job (#6930574334): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (10)
|
|
Test results for linux-wpt-layout-2020 from try job (#6930574334): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (19)
|
|
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will need to do most of the work anyways during the style updates,
so by enabling this it will be easier to detect mistakes.
Also, canvas colors are now parsed as , precisely to support
these new features. This is according to the HTML spec:
https://html.spec.whatwg.org/multipage/infrastructure.html#parsed-as-a-css-color-value
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors