WebIDL: use Uint8Array #31145
Merged
WebIDL: use Uint8Array #31145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taym95
force-pushed
the
WebIDL-use-Uint8Array
branch
2 times, most recently
from
8bfd716
to
1af44fc
Compare
Taym95
commented
Jan 23, 2024
| @@ -112,3 +102,21 @@ impl HeapFloat32Array { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub fn create_typed_array<T, S>( | |||
There was a problem hiding this comment.
@gterzian can you please review this one?
gterzian
approved these changes
Jan 23, 2024
| @@ -2405,6 +2405,7 @@ impl<'a> ContentSizesComputation<'a> { | |||
| had_non_whitespace_content_yet: false, | |||
| linebreaker: None, | |||
| ending_inline_pbm_stack: Vec::new(), | |||
| }.traverse(inline_formatting_context) | |||
| } | |||
| .traverse(inline_formatting_context) | |||
There was a problem hiding this comment.
I think it's best to revert this one so as to keep it focused.
There was a problem hiding this comment.
Yes I will revert, that was result of fmt
Yes, and I will make other PR to address other typed arrays |
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
Taym95
force-pushed
the
WebIDL-use-Uint8Array
branch
from
1af44fc
to
611d253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #31064
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors