Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Int8array, int16array, uint16array, int32array & uint32array in WebIDL #31164

Conversation

Taym95
Copy link
Contributor

@Taym95 Taym95 commented Jan 24, 2024

part #31064


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because there is no behavior changes

There types are not used we can migrate them, in next PR I will make HeapFloat32Array generic and convert ArrayBufferView, ArrayBuffer, Uint8ClampedArray and Float64Array.

…ebIDL

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
@Taym95
Copy link
Contributor Author

Taym95 commented Jan 25, 2024

@gterzian can we merge this one?

Copy link
Member

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This way if any of these were to be used in a web idl in the future(will not happen anytime soon I think), the user would have to use to soon to follow generic typed array.

@gterzian gterzian added this pull request to the merge queue Jan 25, 2024
Merged via the queue into servo:main with commit bb04c97 Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants