layout: Implement computation of table column widths #31165

mrobinson · 2024-01-24T15:58:59Z

This change implements the various steps of table column width
computation, ignoring features that don't exist yet (such as separated
borders, column elements, and colgroups).

Co-authored-by: Oriol Brufau obrufau@igalia.com

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

github-actions · 2024-01-24T15:59:27Z

🔨 Triggering try run (#7642835765) with platforms=linux and layout=2020

github-actions · 2024-01-24T16:50:08Z

Test results for linux-wpt-layout-2020 from try job (#7642835765):

Flaky unexpected result (9)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- TIMEOUT [expected PASS] subtest: looks up handleEvent method on every event dispatch Test timed out
- NOTRUN [expected PASS] subtest: doesn't look up handleEvent method on callable event listeners
- NOTRUN [expected PASS] subtest: rethrows errors when getting handleEvent
- NOTRUN [expected FAIL] subtest: throws if handleEvent is falsy and not callable
- NOTRUN [expected FAIL] subtest: throws if handleEvent is thruthy and not callable
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
TIMEOUT [expected OK] /custom-elements/reactions/customized-builtins/HTMLMediaElement.html (#31014)
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- PASS [expected FAIL] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out

Stable unexpected results that are known to be intermittent (20)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
FAIL [expected TIMEOUT] /css/css-animations/animation-delay-010.html (#26573)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550'
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'italic' over 'oblique 20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
- PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg' over 'normal'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 0deg' over 'oblique -50deg -20deg'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 10deg' over 'italic'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 10deg' should prefer 'italic' over 'oblique 0deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique 40deg 50deg' over 'italic'
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 0deg' should prefer 'italic' over 'oblique -50deg -20deg'
- And 2 more unexpected results...
OK [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/srcdoc/consecutive-srcdoc.html (#29084)
- FAIL [expected TIMEOUT] subtest: changing srcdoc to about:srcdoc#yo then another srcdoc does two push navigations and we can navigate back promise_test: Unhandled rejection with value: object "TypeError: iframe is null"
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank' assert_unreached: load should not be fired Reached unreachable code
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank#foo'
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
PASS [expected FAIL] /html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html (#30684)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
OK /html/semantics/forms/historical.html (#28568)
- FAIL [expected PASS] subtest: <input name=isindex> should not be supported assert_regexp_match: expected object "/?isindex=x$/" but got "about:blank"
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 9606144 but got 9606400
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results (1)

FAIL [expected PASS] /css/CSS2/floats-clear/floats-149.xht

github-actions · 2024-01-24T16:50:43Z

⚠️ Try run (#7642835765) failed.

github-actions · 2024-01-25T08:30:56Z

🔨 Triggering try run (#7651816908) with platforms=linux and layout=2020

github-actions · 2024-01-25T09:21:54Z

Test results for linux-wpt-layout-2020 from try job (#7651816908):

Flaky unexpected result (15)

TIMEOUT [expected OK] /WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any.worker.html
CRASH [expected PASS] /_webgl/conformance/glsl/bugs/long-expressions-should-not-crash.html (#19221)
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
FAIL [expected TIMEOUT] /css/css-animations/animation-delay-010.html (#26573)
OK /css/cssom-view/MediaQueryList-change-event-matches-value.html (#27973)
- FAIL [expected PASS] subtest: MediaQueryList.changed is correct for all lists in the document even during a change event handler assert_equals: Should've fired the change event in both MediaQueryLists expected 2 but got 0
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank' assert_unreached: load should not be fired Reached unreachable code
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- FAIL [expected PASS] subtest: document.write in an imported module assert_true: onload must be called expected true got false
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (13)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '503 520' over '500'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '110% 120%' over '115% 116%' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-stretch: '90%' should prefer '90% 100%' over '50% 80%'
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 10deg 40deg' over 'oblique 20deg 30deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'italic' over 'oblique 20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 21deg' should prefer 'italic' over 'oblique 0deg'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 10deg' should prefer 'italic' over 'oblique 0deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -10deg' over 'italic' assert_equals: Unexpected font on test element expected 487 but got 532
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
OK [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/srcdoc/consecutive-srcdoc.html (#29084)
- FAIL [expected TIMEOUT] subtest: changing srcdoc to about:srcdoc#yo then another srcdoc does two push navigations and we can navigate back promise_test: Unhandled rejection with value: object "TypeError: iframe is null"
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 3] length 2, got [6, 2, 2] length 3
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 5, 3] length 3
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
PASS [expected FAIL] /html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html (#30684)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out

github-actions · 2024-01-25T09:22:26Z

✨ Try run (#7651816908) succeeded.

This change implements the various steps of table column width computation, ignoring features that don't exist yet (such as separated borders, column elements, and colgroups). Co-authored-by: Oriol Brufau <obrufau@igalia.com>

tests/wpt/meta/css/CSS2/floats-clear/floats-149.xht.ini

github-actions · 2024-01-25T15:22:42Z

🔨 Triggering try run (#7656669939) with platforms=linux and layout=2020

mrobinson · 2024-01-25T15:39:10Z

Oh, funny. I didn't see your fix and pushed the exact same fix. :)

github-actions · 2024-01-25T16:11:19Z

Test results for linux-wpt-layout-2020 from try job (#7656669939):

Flaky unexpected result (19)

TIMEOUT [expected PASS] /_mozilla/css/transition_calc_implicit.html (#17417)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
- PASS [expected FAIL] subtest: Instant scrolling while doing history navigation.
TIMEOUT [expected OK] /dom/events/webkit-transition-end-event.html (#26497)
- TIMEOUT [expected FAIL] subtest: webkitTransitionEnd event listener should trigger for an animation Test timed out
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed listener also exists
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener should not trigger if an unprefixed event handler also exists
- NOTRUN [expected FAIL] subtest: event types for prefixed and unprefixed transitionend event listeners should be named appropriately
- NOTRUN [expected PASS] subtest: webkitTransitionEnd event listener is case sensitive
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
CRASH [expected OK] /html/browsers/browsing-the-web/unloading-documents/prompt-and-unload-script-closeable.html
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
TIMEOUT [expected OK] /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- TIMEOUT [expected PASS] subtest: first argument: absolute url Test timed out
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: \r\n in filename (formdata event)
OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)
- FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler assert_array_equals: expected property 1 to be "Script Create azure bindings for Rust #1 ran" but got "Script Handle "close window" event and interrupt signal #3 ran" (expected array ["Script Fix out-of-tree builds #2 ran", "Script Create azure bindings for Rust #1 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran"] got ["Script Fix out-of-tree builds #2 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran", "Script Create azure bindings for Rust #1 ran"])
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
- FAIL [expected PASS] subtest: document.write in an imported module assert_true: onload must be called expected true got false
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
ERROR /resource-timing/content-type-parsing.html (#29131)
- FAIL [expected TIMEOUT] subtest: mime-type 16 : text/html;charset=�gbk assert_equals: expected (string) "text/html" but got (undefined) undefined
- TIMEOUT [expected NOTRUN] subtest: mime-type 17 : text/html;charset=gbk Test timed out
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)

Stable unexpected results that are known to be intermittent (19)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
FAIL [expected TIMEOUT] /css/css-animations/animation-delay-010.html (#26573)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '500' over '400 425'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '340 360' over '200 300'
- PASS [expected FAIL] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '110% 120%' over '115% 116%' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-stretch: '110%' should prefer '50% 80%' over '60% 70%'
- PASS [expected FAIL] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg'
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'italic' over 'oblique 20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 40deg 50deg' over 'oblique 10deg'
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 10deg' should prefer 'italic' over 'oblique 0deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 2 more unexpected results...
OK [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/srcdoc/consecutive-srcdoc.html (#29084)
- FAIL [expected TIMEOUT] subtest: changing srcdoc to about:srcdoc#yo then another srcdoc does two push navigations and we can navigate back assert_equals: expected "about:srcdoc#yo" but got "http://web-platform.test:8000/common/blank.html"
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if
  allow-popups-to-escape-sandbox is used Test timed out
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
PASS [expected FAIL] /html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html (#30684)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: 0x00 in name (normal form) assert_equals: expected "\r\nContent-Disposition: form-data; name="a\0b"\r\n\r\nc\r\n--\r\n" but got ""
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (formdata event)
OK /html/semantics/forms/historical.html (#28568)
- FAIL [expected PASS] subtest: <input name=isindex> should not be supported assert_regexp_match: expected object "/?isindex=x$/" but got "about:blank"
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out

github-actions · 2024-01-25T16:11:50Z

✨ Try run (#7656669939) succeeded.

components/layout_2020/table/layout.rs

mrobinson · 2024-01-25T20:12:12Z

Thanks for the review. I've made all of these changes.

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Jan 24, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 24, 2024

mrobinson requested a review from Loirooriol January 25, 2024 08:28

mrobinson force-pushed the table-layout-column-widths branch from 408edd4 to 19a4bff Compare January 25, 2024 08:30

mrobinson added A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt-2020 Do a try run of the WPT labels Jan 25, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 25, 2024

layout: Implement computation of table column widths

3c96067

This change implements the various steps of table column width computation, ignoring features that don't exist yet (such as separated borders, column elements, and colgroups). Co-authored-by: Oriol Brufau <obrufau@igalia.com>

mrobinson force-pushed the table-layout-column-widths branch from 19a4bff to 3c96067 Compare January 25, 2024 14:12

Loirooriol reviewed Jan 25, 2024

View reviewed changes

tests/wpt/meta/css/CSS2/floats-clear/floats-149.xht.ini Outdated Show resolved Hide resolved

Loirooriol force-pushed the table-layout-column-widths branch 2 times, most recently from 6601e00 to 7b4e989 Compare January 25, 2024 15:21

Loirooriol added the T-linux-wpt-2020 Do a try run of the WPT label Jan 25, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 25, 2024

Fix an issue with the assignment of column percent width

024042f

mrobinson force-pushed the table-layout-column-widths branch from 7b4e989 to 024042f Compare January 25, 2024 15:37

Loirooriol approved these changes Jan 25, 2024

View reviewed changes

components/layout_2020/table/layout.rs Outdated Show resolved Hide resolved

components/layout_2020/table/layout.rs Outdated Show resolved Hide resolved

components/layout_2020/table/layout.rs Outdated Show resolved Hide resolved

Respond to review comments

b93e9e2

mrobinson enabled auto-merge January 25, 2024 20:12

mrobinson added this pull request to the merge queue Jan 25, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024

mrobinson added this pull request to the merge queue Jan 25, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024

mrobinson added this pull request to the merge queue Jan 25, 2024

Merged via the queue into servo:main with commit d68c7e7 Jan 26, 2024
11 checks passed

mrobinson deleted the table-layout-column-widths branch January 26, 2024 00:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

layout: Implement computation of table column widths #31165

layout: Implement computation of table column widths #31165

mrobinson commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

mrobinson commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

mrobinson commented Jan 25, 2024

layout: Implement computation of table column widths #31165

layout: Implement computation of table column widths #31165

Conversation

mrobinson commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 24, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

mrobinson commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

mrobinson commented Jan 25, 2024