layout: Start work on table row height and vertical-align #31246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#7755378350) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7755378350): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (19)
|
|
|
mrobinson
force-pushed
the
table-row-height-1
branch
from
370f3ff
to
309a4c2
Compare
mrobinson
added
A-layout/2020
|
🔨 Triggering try run (#7757564533) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7757564533): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (4)
|
|
|
mrobinson
force-pushed
the
table-row-height-1
branch
from
309a4c2
to
aaa5c14
Compare
|
🔨 Triggering try run (#7813166812) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7813166812): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#7813166812) succeeded. |
Loirooriol
approved these changes
Feb 9, 2024
| layout | ||
| .positioning_context | ||
| .adjust_static_position_of_hoisted_fragments_with_offset( | ||
| &content_rect.start_corner, | ||
| &(&cell_content_rect.start_corner), |
There was a problem hiding this comment.
Suggested change
| &(&cell_content_rect.start_corner), | |
| &cell_content_rect.start_corner, |
components/layout_2020/flow/mod.rs
Outdated
Comment on lines
1428
to
1430
| match (self.inflow_baselines.first, box_fragment.baselines.first) { | ||
| (None, Some(first)) => self.inflow_baselines.first = Some(first + box_block_offset), | ||
| _ => {}, | ||
| } |
There was a problem hiding this comment.
This was already the case, but BTW clippy would prefer
Suggested change
| match (self.inflow_baselines.first, box_fragment.baselines.first) { | |
| (None, Some(first)) => self.inflow_baselines.first = Some(first + box_block_offset), | |
| _ => {}, | |
| } | |
| if let (None, Some(first)) = (self.inflow_baselines.first, box_fragment.baselines.first) { | |
| self.inflow_baselines.first = Some(first + box_block_offset) | |
| } |
This implements a very naive row height allocation approach. It has just enough to implement `vertical-align` in table cells. Rowspanned cells get enough space for their content, with the extra space necessary being allocated to the last row. There's still a lot missing here, including proper distribution of row height to rowspanned cells. Co-authored-by: Oriol Brufau <obrufau@igalia.com>
mrobinson
force-pushed
the
table-row-height-1
branch
from
aaa5c14
to
9db9efc
Compare
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 11, 2024
This implements a very naive row height allocation approach. It has just enough to implement `vertical-align` in table cells. Rowspanned cells get enough space for their content, with the extra space necessary being allocated to the last row. There's still a lot missing here, including proper distribution of row height to rowspanned cells. Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout: Start work on table row height and vertical-align
This implements a very naive row height allocation approach. It has just
enough to implement
vertical-alignin table cells. Rowspanned cellsget enough space for their content, with the extra space necessary being
allocated to the last row. There's still a lot missing here, including
proper distribution of row height to rowspanned cells.
Co-authored-by: Oriol Brufau obrufau@igalia.com
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors