canvas2d: Implement .reset() - #31258
Merged
Merged
Conversation
mrobinson
approved these changes
Feb 5, 2024
mrobinson
left a comment
mrobinson
left a comment
Member
There was a problem hiding this comment.
What a great change! I just have a few comments about the rustdoc. Note that most of the pre-existing comments of this form should be converted as well.
mrobinson
enabled auto-merge
February 5, 2024 08:22
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 11, 2024
* Implement Canvas2D reset * Update WPT tests * Apply suggestions from code review --------- Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
.reset()forCanvasRenderingContext2D, which resets the rendering context to its default state. There is already logic for resetting the rendering context for when the width/height is changed, so the implementation is similar../mach build -ddoes not report any errors./mach test-tidydoes not report any errors