Implement HTMLImageElement decode #31269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#8093180833) for Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#8093180833): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (7)
|
|
|
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
|
@Taym95 Do you mind taking a look at the failing tests? It seems that this change introduces some failure and timeouts. |
I pushed another commit after last |
|
🔨 Triggering try run (#8111488522) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8111488522): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (4)
|
|
|
gterzian
requested changes
Mar 4, 2024
|
@Taym95 Any updates on this one? Is there some way that I can help you get this ready for review again? |
Sorry, @mrobinson, I was busy in previous weeks. I will continue working on this this week. |
Taym95
force-pushed
the
Implement-HTMLImageElement-decode
branch
2 times, most recently
from
c1df1b6
to
d3f2d8b
Compare
@mrobinson Can you run |
mrobinson
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#9348660545) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#9348660545): Flaky unexpected result (7)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (4)
|
|
Test results for linux-wpt-layout-2020 from try job (#9348660545): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (4)
|
…ilable Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
Thanks, I addressed these remarks |
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
gterzian
requested changes
Jun 11, 2024
| for promise in self.image_decode_promises.borrow().iter() { | ||
| promise.resolve_native(&()); | ||
| } | ||
| self.image_decode_promises.borrow_mut().clear(); |
There was a problem hiding this comment.
would it not be better to just do a drain(...) above?
There was a problem hiding this comment.
We can use drain(..) from the doc I saw:
/// // A full range clears the vector, like `clear()` does
/// v.drain(..);
/// assert_eq!(v, &[]);
| @@ -1345,6 +1397,9 @@ pub enum ImageElementMicrotask { | |||
| elem: DomRoot<HTMLImageElement>, | |||
| generation: u32, | |||
| }, | |||
| DecodeTask { | |||
| elem: DomRoot<HTMLImageElement>, | |||
There was a problem hiding this comment.
One last thing I thought about: there is currently a race condition between when the microtask runs, and the "in parallel" stuff described at 2.2. For example if the request becomes broken, we will reject all promises, including the one for which the micro task hasn't run yet.
I'm not sure this is actually a problem, but we may as well be consitent with the spec and:
- In
Decode, not store the promise onpending_, but rather store it here in the task. - change
react_to_decode_image_sync_stepsas described above.
There was a problem hiding this comment.
I moved storing promise in task and tests are okey
| if !document.is_fully_active() || | ||
| matches!(self.current_request.borrow().state, State::Broken) | ||
| { | ||
| self.reject_image_decode_promises(); |
There was a problem hiding this comment.
here, as per the comment below, let's only reject the promise associated with the task, and remove the resolve logic below. Instead, if the promise is not rejected, we should store it on pending_, and resolve/reject it later as the request state changes.
I'm going to run the wpt tests before this change, and after, just to see if this makes a difference.
There was a problem hiding this comment.
I removed the resolve logic but it broke lot of tests.
There was a problem hiding this comment.
Ok, I will just run the tests once to see, but probably we should then keep it. I guess its a kind of race condition in the spec, between the microtask and the parallel steps.
|
🔨 Triggering try run (#9464494120) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9464494120): Flaky unexpected result (10)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#9464494120) succeeded. |
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
|
🔨 Triggering try run (#9470224661) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#9470224661): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (3)
|
|
|
gterzian
requested changes
Jun 11, 2024
| @@ -1173,7 +1173,11 @@ impl HTMLImageElement { | |||
| } | |||
|
|
|||
| // Step 2 for <https://html.spec.whatwg.org/multipage/#dom-img-decode> | |||
| fn react_to_decode_image_sync_steps(&self) { | |||
| fn react_to_decode_image_sync_steps(&self, promise: Rc<Promise>) { | |||
| self.image_decode_promises | |||
There was a problem hiding this comment.
What I meant is that we should only resolve or reject this particular promise here, and if neither happens, at the end of the function store it into this.
|
Note also there is a discussion ongoing about the potential race condition I mentioned, at whatwg/html#4217. |
This reverts commit eee6096.
Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
gterzian
approved these changes
Jun 12, 2024
| &document.global(), | ||
| DOMErrorName::EncodingError, | ||
| )); | ||
| } else if matches!( |
There was a problem hiding this comment.
Here I would add a comment that this does not follow the spec, but it is discussed at whatwg/html#4217
…ailable Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
|
Thank you, great work! @Taym95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors