layout: Respond to shorthand property requests with real values #31277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the maintainer approving the workflows on this also kick off a WPT run? |
|
🔨 Triggering try run (#7826667521) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#7826667521): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (19)
|
|
Test results for linux-wpt-layout-2020 from try job (#7826667521): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (10)
|
|
|
Taym95
reviewed
Feb 8, 2024
|
Ive found that there is a generated type LonghandsToSerialize that seem to include the correct logic for only serializing properties of shorthands that are allowed in the shorthands servo/components/style/properties/shorthands/font.mako.rs Lines 219 to 225 in 5facf43 There are also some WPT tests that use shorthands that are failing because the serialization is expected to be returned in a shorter form than what this solution currently generates. Its not clear to me that shorter forms can be generated without knowing which longhand properties were set and which are default? |
Loirooriol
reviewed
Feb 9, 2024
Comment on lines
19
to
9
|
|
||
| [Can't serialize shorthand set to initial value when some longhand is missing] | ||
| expected: FAIL |
There was a problem hiding this comment.
This shouldn't be regressing, but it's not your fault, you will need to rebase after #31299
Signed-off-by: Sebastian C <sebsebmc@gmail.com>
Signed-off-by: Sebastian C <sebsebmc@gmail.com>
Signed-off-by: Sebastian C <sebsebmc@gmail.com>
Signed-off-by: Sebastian C <sebsebmc@gmail.com>
sebsebmc
force-pushed
the
shorthand-computed-properties
branch
from
e649f25
to
5ca70a1
Compare
Loirooriol
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#7849202580) for Linux WPT legacy-layout, Linux WPT layout-2020 |
|
Test results for linux-wpt-layout-2020 from try job (#7849202580): Flaky unexpected result (6)
Stable unexpected results that are known to be intermittent (20)
Stable unexpected results (10)
|
|
|
Loirooriol
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
You need to update the test expectations.
So if I get it right, the regressions are:
/html/rendering/non-replaced-elements/the-hr-element-0/hr.html, addressed by <hr> elements are expected to have a default overflow:hidden #31297/css/css-fonts/font-shorthand-serialization-prevention.htmlbecause servo doesn't supportall-small-caps/css/css-backgrounds/animations/background-position-interpolation.html
It would be good to land #31297 first and investigate what's happening with background-position-interpolation.html, but otherwise this looks good.
Comment on lines
19
to
9
|
|
||
| [Can't serialize shorthand set to initial value when some longhand is missing] | ||
| expected: FAIL |
|
|
|
No, the test fails because Servo doesn't support Therefore, the assignment fails, and the longhands can be represented by a shorthand value, so the shorthand serializes. |
|
|
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 11, 2024
…o#31277) * Respond to shorthand property requests with real values Signed-off-by: Sebastian C <sebsebmc@gmail.com> * Cleanup formatting and old comments Signed-off-by: Sebastian C <sebsebmc@gmail.com> * Update WPT expectations Signed-off-by: Sebastian C <sebsebmc@gmail.com> * Refactor out helper fn Signed-off-by: Sebastian C <sebsebmc@gmail.com> * Cleanup Signed-off-by: Sebastian C <sebsebmc@gmail.com> --------- Signed-off-by: Sebastian C <sebsebmc@gmail.com>
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 14, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 14, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 14, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 15, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 15, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
syvb
added a commit
to syvb/servo
that referenced
this pull request
Feb 15, 2024
…o#31277) (full) {"fail_fast": false, "matrix": [{"name": "Linux WPT", "workflow": "linux", "wpt_layout": "all", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "MacOS", "workflow": "macos", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Windows", "workflow": "windows", "wpt_layout": "none", "profile": "release", "unit_tests": true, "wpt_tests_to_run": ""}, {"name": "Android", "workflow": "android", "wpt_layout": "none", "profile": "release", "unit_tests": false, "wpt_tests_to_run": ""}]}
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Apr 26, 2024
This ports servo#31277 (with the changes from servo#32066) into legacy layout. Otherwise, turning white-space into a shorthand (servo#32146) would fail some tests that expect the property to be serializable.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of responding with an empty string for shorthand properties, use the mapped longhand properties to respond to computed style requests.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors/css/css-flexbox/parsing/flex-computed.html,/css/css-flexbox/parsing/flex-flow-computed.htmland/css/css-animations/computed-style-animation-parsing.html