mach: Make ./mach try a little friendlier
#31290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
reviewed
Feb 8, 2024
sagudev
reviewed
Feb 8, 2024
sagudev
reviewed
Feb 8, 2024
mrobinson
force-pushed
the
try-improvements
branch
from
981903e
to
a4728b9
Compare
|
@sagudev Thanks for the review. I've made the changes you've requested. |
sagudev
reviewed
Feb 8, 2024
sagudev
reviewed
Feb 8, 2024
sagudev
reviewed
Feb 8, 2024
sagudev
reviewed
Feb 8, 2024
mrobinson
force-pushed
the
try-improvements
branch
2 times, most recently
from
aa42d10
to
8e2842a
Compare
sagudev
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Something is wrong: https://github.com/sagudev/servo/actions/runs/7828494013/job/21358490263#step:5:54
I ran mach try webgpu full
1. Move `./mach try` to `testing_commands.py which is a bit more consistent. 2. Make `./mach try` print out the remote name always and properly form the URL for ssh repositories. 3. Print out the try configuration matrix to make it more obvious what is being triggered remotely. 4. Better error handling. Print and error and exit if the remote isn't on GitHub and also clean up properly if something fails after making the temporary commit.
mrobinson
force-pushed
the
try-improvements
branch
from
8e2842a
to
61ef0d5
Compare
It seems there was a bug when the commit message was more than a single line. I think I've fixed that now. |
|
Here's an example of the same test you ran: https://github.com/mrobinson/servo/actions/runs/7828643293/job/21358950457 |
sagudev
approved these changes
Feb 8, 2024
Sure thing. Thanks for implementing it originally. It's really useful! |
Taym95
pushed a commit
to Taym95/servo
that referenced
this pull request
Feb 11, 2024
1. Move `./mach try` to `testing_commands.py which is a bit more consistent. 2. Make `./mach try` print out the remote name always and properly form the URL for ssh repositories. 3. Print out the try configuration matrix to make it more obvious what is being triggered remotely. 4. Better error handling. Print and error and exit if the remote isn't on GitHub and also clean up properly if something fails after making the temporary commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach tryto `testing_commands.py which is a bit moreconsistent.
./mach tryprint out the remote name always and properlyform the URL for ssh repositories.
what is being triggered remotely.
on GitHub and also clean up properly if something fails after making
the temporary commit.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors