layout: Use `BoxFragment` border widths for display list generation #31292

mrobinson · 2024-02-08T11:36:47Z

Instead of using the border widths from the style, use the ones recorded by the BoxFragment. This is necessary because inline layout can override these border widths during fragmentation. For instance, when a box is split across two lines only one fragment should have an inline start border.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

github-actions · 2024-02-08T11:37:33Z

🔨 Triggering try run (#7829004054) for Linux WPT layout-2020

github-actions · 2024-02-08T12:19:08Z

Test results for linux-wpt-layout-2020 from try job (#7829004054):

Flaky unexpected result (14)

FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes Test timed out
- NOTRUN [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- NOTRUN [expected TIMEOUT] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
FAIL [expected PASS] /html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html (#30684)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: \r\n in value (normal form)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
- FAIL [expected PASS] subtest: document.write in an imported module assert_true: onload must be called expected true got false
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (14)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-animations/animation-delay-010.html (#26573)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '420 440' over '450 460'
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '503 520' over '500'
- PASS [expected FAIL] subtest: Matching font-weight: '501' should prefer '500' over '450 460'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '340 360' over '200 300'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- And 11 more unexpected results...
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected FAIL] subtest: looks up handleEvent method on every event dispatch
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus assert_equals: expected Element node <area></area> but got Element node <body>
  <img src="/media/poster.png" usemap="#map">
  <map n...
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: DOMParser
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
ERROR /resource-timing/content-type-parsing.html (#29131)
- TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
- NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset=gbk
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

Stable unexpected results (73)

PASS [expected FAIL] /css/CSS2/box/ltr-basic.xht
PASS [expected FAIL] /css/CSS2/box/ltr-ib.xht
PASS [expected FAIL] /css/CSS2/box/ltr-span-only-ib.xht
PASS [expected FAIL] /css/CSS2/box/ltr-span-only.xht
PASS [expected FAIL] /css/CSS2/css1/c42-ibx-ht-000.xht
PASS [expected FAIL] /css/CSS2/linebox/inline-box-001.xht
PASS [expected FAIL] /css/CSS2/linebox/inline-formatting-context-022.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-append-002-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-append-002-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-append-002.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-001-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-001-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-001a.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-002-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-002-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-002a.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-003-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-003-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-003.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-004-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-004-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-004.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-007-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-007-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-007.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-008-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-008-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-008a.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-009-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-009-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-009.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-010-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-010-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-010.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-011-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-011-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-011.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-012-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-012-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-012.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-013-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-013-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-013.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-014-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-014-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-014.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-015-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-015-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-015.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-016-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-016-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-016a.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-insert-017.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-001-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-001-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-001.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-003-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-003-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-003.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-004-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-004-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-004.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-005-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-005-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-005.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-006-nosplit-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-006-ref.xht
PASS [expected FAIL] /css/CSS2/normal-flow/block-in-inline-remove-006.xht
PASS [expected FAIL] /css/CSS2/visuren/remove-from-split-inline-1-ref.html
PASS [expected FAIL] /css/CSS2/visuren/remove-from-split-inline-3-ref.html
PASS [expected FAIL] /css/CSS2/visuren/remove-from-split-inline-4-ref.html
PASS [expected FAIL] /css/CSS2/visuren/remove-from-split-inline-5-ref.html
PASS [expected FAIL] /css/CSS2/visuren/remove-from-split-inline-6-ref.html

github-actions · 2024-02-08T12:19:17Z

⚠️ Try run (#7829004054) failed.

mrobinson · 2024-02-08T12:48:45Z

This is ready to review. I need to update the results, but the difference is 73 new passes.

github-actions · 2024-02-08T19:03:12Z

🔨 Triggering try run (#7834603727) for Linux WPT layout-2020

github-actions · 2024-02-08T19:42:41Z

Test results for linux-wpt-layout-2020 from try job (#7834603727):

Flaky unexpected result (18)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected PASS] /_mozilla/css/transition_calc_implicit.html (#17417)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected FAIL] /css/css-animations/animation-delay-010.html (#26573)
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected FAIL] subtest: looks up handleEvent method on every event dispatch
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='' assert_unreached: load should not be fired Reached unreachable code
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked assert_equals: expected "A" but got ""
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked assert_equals: expected "�ÿ" but got ""
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: characters not in encoding in name and value (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: lone surrogate in name and value (normal form)
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)
- FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler assert_array_equals: expected property 1 to be "Script Create azure bindings for Rust #1 ran" but got "Script Handle "close window" event and interrupt signal #3 ran" (expected array ["Script Fix out-of-tree builds #2 ran", "Script Create azure bindings for Rust #1 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran"] got ["Script Fix out-of-tree builds #2 ran", "Script Handle "close window" event and interrupt signal #3 ran", "Script Bind harfbuzz #4 ran", "Script Create azure bindings for Rust #1 ran"])
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 4073472 but got 4073728
TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
OK /xhr/xhr-timeout-longtask.any.html (#27663)
- FAIL [expected PASS] subtest: Long tasks should not trigger load timeout assert_unreached: [object ProgressEvent] Reached unreachable code

Stable unexpected results that are known to be intermittent (18)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-weight: '400' should prefer '450 460' over '500'
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '200 300' over '400'
- PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '500 501' over '502 510'
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 10deg 40deg' over 'oblique 20deg 30deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 10 more unexpected results...
PASS [expected TIMEOUT] /css/css-transitions/render-blocking/no-transition-from-ua-to-blocking-stylesheet.html (#29187)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes Test timed out
- NOTRUN [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- NOTRUN [expected TIMEOUT] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
- PASS [expected FAIL] subtest: DOMParser
- PASS [expected FAIL] subtest: createHTMLDocument
- PASS [expected FAIL] subtest: <template>
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
TIMEOUT /html/webappapis/scripting/events/compile-event-handler-settings-objects.html (#24246)
- FAIL [expected PASS] subtest: The entry settings object while executing the compiled callback via Web IDL's invoke must be that of the node document assert_equals: expected "/html/webappapis/scripting/events/resources/open-window.html" but got "blank"
ERROR /resource-timing/content-type-parsing.html (#29131)
- TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
- NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset=gbk
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)

Stable unexpected results (2)

PASS [expected FAIL] /css/CSS2/box/ltr-basic.xht
PASS [expected FAIL] /css/CSS2/box/ltr-ib.xht

github-actions · 2024-02-08T19:42:51Z

⚠️ Try run (#7834603727) failed.

Instead of using the border widths from the style, use the ones recorded by the `BoxFragment`. This is necessary because inline layout can override these border widths during fragmentation. For instance, when a box is split across two lines only one fragment should have an inline start border.

github-actions · 2024-02-08T19:50:51Z

🔨 Triggering try run (#7835144442) for Linux WPT layout-2020

github-actions · 2024-02-08T20:34:15Z

Test results for linux-wpt-layout-2020 from try job (#7835144442):

Flaky unexpected result (15)

CRASH [expected PASS] /_webgl/conformance/glsl/bugs/nested-functions-should-not-crash.html (#30680)
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
TIMEOUT [expected OK] /html/browsers/browsing-the-web/history-traversal/srcdoc/consecutive-srcdoc.html (#29084)
- TIMEOUT [expected FAIL] subtest: changing srcdoc does a replace navigation since the URL is still about:srcdoc Test timed out
- NOTRUN [expected FAIL] subtest: changing srcdoc to about:srcdoc#yo then another srcdoc does two push navigations and we can navigate back
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
- PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
TIMEOUT [expected OK] /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
- TIMEOUT [expected PASS] subtest: first argument: absolute url Test timed out
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task Test timed out
TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html (#25805)
- TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise Test timed out
- TIMEOUT [expected FAIL] subtest: Rejection handler on pending-then-rejected promise Test timed out
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img) assert_equals: expected 5813248 but got 5812992
TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript: Test timed out
TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out

Stable unexpected results that are known to be intermittent (20)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '400' should prefer '351 398' over '501 550' assert_equals: Unexpected font on test element expected 487 but got 532
- PASS [expected FAIL] subtest: Matching font-weight: '430' should prefer '400 425' over '350 399'
- FAIL [expected PASS] subtest: Matching font-weight: '430' should prefer '501 550' over '502 560' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '450 460' over '400' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-stretch: '100%' should prefer '100%' over '110% 120%' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 10deg 40deg' over 'oblique 20deg 30deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'normal' should prefer 'oblique 20deg 30deg' over 'oblique -50deg -20deg' assert_equals: Unexpected font on test element expected 487 but got 532
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 40deg 50deg' over 'oblique 5deg 10deg' assert_equals: Unexpected font on test element expected 487 but got 532
- And 4 more unexpected results...
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- PASS [expected FAIL] subtest: looks up handleEvent method on every event dispatch
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
- TIMEOUT [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes Test timed out
- NOTRUN [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes
- NOTRUN [expected TIMEOUT] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout assert_equals: Expected nested setTimeout to run second expected true but got false
- FAIL [expected PASS] subtest: Check execution order on load handler assert_equals: Expected onload to run first expected false but got true
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Host element with delegatesFocus should support autofocus promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped promise_test: Unhandled rejection with value: object "TypeError: host.attachShadow is not a function"
- FAIL [expected NOTRUN] subtest: Area element should support autofocus promise_test: Unhandled rejection with value: object "TypeError: w.document.querySelector(...) is null"
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- FAIL [expected PASS] subtest: Check that rel=noopener with target=_self does a normal load this.openedWindow.findLink is not a function
OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
ERROR /resource-timing/content-type-parsing.html (#29131)
- TIMEOUT [expected FAIL] subtest: mime-type 16 : text/html;charset=�gbk Test timed out
- NOTRUN [expected TIMEOUT] subtest: mime-type 17 : text/html;charset=gbk
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
OK [expected ERROR] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

github-actions · 2024-02-08T20:34:25Z

✨ Try run (#7835144442) succeeded.

components/layout_2020/flow/line.rs

…ervo#31292) Instead of using the border widths from the style, use the ones recorded by the `BoxFragment`. This is necessary because inline layout can override these border widths during fragmentation. For instance, when a box is split across two lines only one fragment should have an inline start border.

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

mrobinson marked this pull request as ready for review February 8, 2024 12:48

mrobinson force-pushed the border-widths-from-fragment branch from fbd7f48 to 6884b0d Compare February 8, 2024 19:02

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

mrobinson force-pushed the border-widths-from-fragment branch from 6884b0d to 14c39ae Compare February 8, 2024 19:50

mrobinson added the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Feb 8, 2024

Loirooriol approved these changes Feb 8, 2024

View reviewed changes

Loirooriol reviewed Feb 8, 2024

View reviewed changes

components/layout_2020/flow/line.rs Show resolved Hide resolved

Loirooriol added this pull request to the merge queue Feb 8, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024

mrobinson added this pull request to the merge queue Feb 8, 2024

Merged via the queue into servo:main with commit f6b81a9 Feb 9, 2024
37 checks passed

mrobinson deleted the border-widths-from-fragment branch February 9, 2024 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

layout: Use `BoxFragment` border widths for display list generation #31292

layout: Use `BoxFragment` border widths for display list generation #31292

mrobinson commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

mrobinson commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

layout: Use BoxFragment border widths for display list generation #31292

layout: Use BoxFragment border widths for display list generation #31292

Conversation

mrobinson commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

mrobinson commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

github-actions bot commented Feb 8, 2024

layout: Use `BoxFragment` border widths for display list generation #31292

layout: Use `BoxFragment` border widths for display list generation #31292